ManagedCluster controller test enhancement

[BROngineer]

Description

Current test suite runs reconciliation and checks whether error occurred or not:

hmc/internal/controller/managedcluster_controller_test.go

Lines 215 to 226 in 2e92fb6

	It("should successfully reconcile the resource", func() {
	By("Reconciling the created resource")
	controllerReconciler := &ManagedClusterReconciler{
	Client: k8sClient,
	Config: &rest.Config{},
	}
	_, err := controllerReconciler.Reconcile(ctx, reconcile.Request{
	NamespacedName: typeNamespacedName,
	})
	Expect(err).NotTo(HaveOccurred())
	})

However, reconciler exits after adding finalizer to the resource being reconciled:

// managedcluster_controller.go

...
func (r *ManagedClusterReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
    ...
    return r.reconcileUpdate(ctx, managedCluster)
}

func (r *ManagedClusterReconciler) reconcileUpdate(ctx context.Context, mc *hmc.ManagedCluster) (_ ctrl.Result, err error) {
...

    if controllerutil.AddFinalizer(mc, hmc.ManagedClusterFinalizer) {
        if err := r.Client.Update(ctx, mc); err != nil {
            return ctrl.Result{}, fmt.Errorf("failed to update managedCluster %s/%s: %w", mc.Namespace, mc.Name, err)
        }
        return ctrl.Result{}, nil
    }
...

Expected behaviour

Object should be reconciled until it eventually enters desired state defined by test-case parameters or test should fail by timeout.