Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce compatibility for service deployment in MultiClusterService #782

Open
wahabmk opened this issue Dec 11, 2024 · 1 comment
Open

Comments

@wahabmk
Copy link
Contributor

wahabmk commented Dec 11, 2024

Since the MultiClusterService object also uses the same ServiceTemplateSpec as ManagedCluster, should we enforce compatibility for service deployment on it as well?

Although we can't do it the way it is done for ManagedCluster in the admission webhooks as we can't know beforehand which clusters the MultiClusterService will match.

@zerospiel
Copy link
Member

it could be checked within the mcs controller during the reconciliation, as it is now implemented in the template-ctrl (templates also cannot be checked in the validating webhook)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants