Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance operator config controller #6

Merged

Conversation

adrianchiris
Copy link
Collaborator

Refer to individual commits for context.

this is needed to later update log level using
maintenenace operator config controller

Signed-off-by: adrianc <[email protected]>
- add vars package which container operator namesepace
  taken from env variable
- update manager to expose operator namespace via env var

Signed-off-by: adrianc <[email protected]>
- implement NodeMaintenanceSchedulerReconcilerOptions which
allows to update reconciler options during runtime in a
async manner
- update controller to use NodeMaintenanceSchedulerReconcilerOptions
- update unit tests

Signed-off-by: adrianc <[email protected]>
- implement NodeMaintenanceReconcilerOptions which
allows to update reconciler options during runtime in a async manner
- update controller to use NodeMaintenanceReconcilerOptions
- update unit tests

Signed-off-by: adrianc <[email protected]>
the reconciler reconciles default MaintenanceOperatorConfig CR
by updating log and reconciler options of both controllers

Signed-off-by: adrianc <[email protected]>
update main with changes introduced in this set
of commits

- use log from log package
- initialize options for reconcilers
- pass reconciler options to operator config reconciler

Signed-off-by: adrianc <[email protected]>
@coveralls
Copy link

coveralls commented Jul 25, 2024

Pull Request Test Coverage Report for Build 10131277832

Details

  • 99 of 132 (75.0%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+7.9%) to 56.219%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/log/log.go 17 22 77.27%
internal/controller/maintenanceoperatorconfig_controller.go 17 24 70.83%
cmd/maintenance-manager/main.go 0 21 0.0%
Files with Coverage Reduction New Missed Lines %
internal/controller/nodemaintenancescheduler_controller.go 2 82.48%
Totals Coverage Status
Change from base Build 10094410633: 7.9%
Covered Lines: 452
Relevant Lines: 804

💛 - Coveralls

Signed-off-by: adrianc <[email protected]>
@adrianchiris adrianchiris mentioned this pull request Jul 28, 2024
Copy link
Collaborator

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykulazhenkov ykulazhenkov merged commit afa2376 into Mellanox:main Jul 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants