-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance operator config controller #6
Merged
ykulazhenkov
merged 8 commits into
Mellanox:main
from
adrianchiris:maintenance-operator-config-controller
Jul 29, 2024
Merged
Maintenance operator config controller #6
ykulazhenkov
merged 8 commits into
Mellanox:main
from
adrianchiris:maintenance-operator-config-controller
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is needed to later update log level using maintenenace operator config controller Signed-off-by: adrianc <[email protected]>
- add vars package which container operator namesepace taken from env variable - update manager to expose operator namespace via env var Signed-off-by: adrianc <[email protected]>
Signed-off-by: adrianc <[email protected]>
- implement NodeMaintenanceSchedulerReconcilerOptions which allows to update reconciler options during runtime in a async manner - update controller to use NodeMaintenanceSchedulerReconcilerOptions - update unit tests Signed-off-by: adrianc <[email protected]>
- implement NodeMaintenanceReconcilerOptions which allows to update reconciler options during runtime in a async manner - update controller to use NodeMaintenanceReconcilerOptions - update unit tests Signed-off-by: adrianc <[email protected]>
the reconciler reconciles default MaintenanceOperatorConfig CR by updating log and reconciler options of both controllers Signed-off-by: adrianc <[email protected]>
update main with changes introduced in this set of commits - use log from log package - initialize options for reconcilers - pass reconciler options to operator config reconciler Signed-off-by: adrianc <[email protected]>
Pull Request Test Coverage Report for Build 10131277832Details
💛 - Coveralls |
Signed-off-by: adrianc <[email protected]>
Merged
ykulazhenkov
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to individual commits for context.