Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing Periods #12

Open
xueharry opened this issue Jun 6, 2017 · 4 comments
Open

Trailing Periods #12

xueharry opened this issue Jun 6, 2017 · 4 comments

Comments

@xueharry
Copy link

xueharry commented Jun 6, 2017

I've noticed that the model's predictions all have trailing periods. For example:

Q Possibly even for good reasons.
A Possibly even for good reasons.
☒ Possibly even for good rensuss..............................

Is this possibly a bug?

@xueharry
Copy link
Author

Figured it out. I ended up adding an end of sequence token to the training data so that the model ended up learning when to terminate outputs.

@parth126
Copy link

@xueharry Can you share the new working code please? or maybe send a pull request.

@FMFluke
Copy link

FMFluke commented Nov 16, 2017

@xueharry Can you please explain more about it? What did you use as an end of sequence and how did the model know where to terminate outputs?

@SoundBot
Copy link

@MajorTal any word of advice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants