Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi4j is archived #9

Open
rlratcliffe opened this issue Apr 15, 2024 · 2 comments
Open

openapi4j is archived #9

rlratcliffe opened this issue Apr 15, 2024 · 2 comments

Comments

@rlratcliffe
Copy link
Collaborator

rlratcliffe commented Apr 15, 2024

Using the archetype with camel-rest-extensions, when migrating APIs where the specification paths cannot be changed, this path pattern collision issue sometimes occurs. There may be other bugs but this seems to be the most common one.

Since openapi4j is archived, it means there's no support for fixing bugs like this.

Alternative libraries:

  • com.atlassian.oai swagger-request-validator-core is already part of this project and according to this camel-rest-extensions merged PR it was switched from because it didn't offer XML support, and there is still an open issue for XML support with the validator
  • ?
@rlratcliffe
Copy link
Collaborator Author

rlratcliffe commented Apr 15, 2024

My short term plan in order to support this for clients who need this fix is to fork the openapi4j version to fix the bug and then update camel-rest extensions to use the forked version.

Long term, I don't think it's a good idea to use a forked openapi4j version that we would also need to maintain. But switching to a whole new validator library requires significantly more changes and figuring out the acceptance criteria to ensure previous functionality is not broken.

@rlratcliffe
Copy link
Collaborator Author

Short term plan is complete:
Released new openapi4j on github: https://github.com/MS3Inc/openapi4j/releases/tag/MS3-1.0.8
Released snapshot version of camel-rest-extensions: https://github.com/MS3Inc/camel-rest-extensions/releases/tag/0.1.7-SNAPSHOT
Updated archetype branch (not merged to main yet): https://github.com/MS3Inc/camel-archetypes/tree/version-updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant