Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEG - Remove unused fields in subject_info.json #8

Open
allermat opened this issue Apr 24, 2024 · 2 comments
Open

MEG - Remove unused fields in subject_info.json #8

allermat opened this issue Apr 24, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@allermat
Copy link
Collaborator

allermat commented Apr 24, 2024

There are fields in the subject_info.json file which aren't explicitly used by the code such as, meg_id, meg_date, mri_id and mri_date. This is because all those are also included in the corresponding file paths which are actually used in the code.

I thought it is nice to have those fields as when you look at the subject_info.json file you can immediately identify which subject is which based on those fields, but I acknowledge that those fields aren't strictly necessary.

Shall we keep or get rid of them?

Let me know what you think @RikHenson, @dcdace, @olafhauk

Thanks!

@allermat allermat added the question Further information is requested label Apr 24, 2024
@allermat allermat self-assigned this Apr 24, 2024
@allermat allermat changed the title Unused fields in subject_info.json MEG - Unused fields in subject_info.json Apr 25, 2024
@RikHenson
Copy link
Member

I would remove unused fields, to also reduce problem of PID, though I guess people will share BIDS repositories but not necessarily the scripts that produce the BIDS...

@allermat
Copy link
Collaborator Author

I guess people will share BIDS repositories but not necessarily the scripts that produce the BIDS...

Indeed, the subject_info.json is not for sharing.

@allermat allermat added the enhancement New feature or request label Apr 25, 2024
@allermat allermat changed the title MEG - Unused fields in subject_info.json MEG - Remove unused fields in subject_info.json Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants