From d00d5df78bc2b1b5dfe023dec968a26f5407e7f2 Mon Sep 17 00:00:00 2001 From: Sander Saarend Date: Tue, 20 Feb 2024 11:15:08 +0200 Subject: [PATCH 01/12] Report inboxes --- 0000-report-inboxes.md | 65 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100644 0000-report-inboxes.md diff --git a/0000-report-inboxes.md b/0000-report-inboxes.md new file mode 100644 index 0000000..755e7c6 --- /dev/null +++ b/0000-report-inboxes.md @@ -0,0 +1,65 @@ +- Feature Name: report-inboxes +- Start Date: 2024-02-20 +- RFC PR: [LemmyNet/rfcs#0000](https://github.com/LemmyNet/rfcs/pull/0000) +- Lemmy Issue: [LemmyNet/lemmy#0000](https://github.com/LemmyNet/lemmy/issues/0000) + +# Summary + +Rather than combining all reports into a single reprt inbox, we should allow users to select whether they are reporting to mods or admins, and we should split reports into different inboxes based on that selection. + +# Motivation + +The current approach has some shortcomings: + +* Users are not currently able to bypass mods and report directly to admins - this may allow mods to conceal instance rule breaking in specific communities +* Admins are not aware of community rules, so they may wish to take no action for most community rule breaking reports. However, if an admin resolves such a report, the relevant community mods most likely never see it. +* Different instances may have different rules, but somebody resolving a report on one instance will resolve it for other instances as well, thus potentially resulting in missed reports. +* Mods might take local action on a report and mark it as resolved even in cases where a user should be banned from the entire instance. In this case, admins are very unlikely to see the report. + +# Guide-level explanation + +1. Whe creating reports, users are able to select if it's a mod report, or an admin report +![image](https://github.com/sunaurus/lemmy-rfcs/assets/5356547/9a21b527-6c88-4024-b287-3371d77688f4) + +2. Instead of the current single report inbox, there will be three different kinds of inboxes: + * Admin reports - show all reports sent to admins (only visible to admins) + * Mod reports - show all reports sent to mods for any communities the user moderates + * All reports - Shows a read-only view of all (admin and mod) reports, only visible to admins + * This would allow admins to still keep an eye on mod actions on their instance if they wish +The UI wouldn't need to change for mods, but for admins, there would be a new selection at the top of the reports page (the "mod reports" tab would only be visible if the admin is also a mod in any community): +![image](https://github.com/sunaurus/lemmy-rfcs/assets/5356547/cc4ad68c-6e85-4cd9-b324-131c06951cb3) + +3. Resolving reports should be more granular + * Reports in the "admin reports" tab can only be resolved for admins of the local instance + * To reduce overhead, **banning reported user on the user's home instance + removing reported content should automatically resolve reports for remote admins as well** + * Reports in the "mod reports" tab can only be resolved by relevant mods. Admins can only reoslve these if they are also explicit mods in the relevant communities. + * To reduve overhead, **banning reported user on the communities instance + removing reported content should automatically resolve reports for mods as well** + * Reports in the "all reports" tab can not be resolved, they are only there for a read-only overview + * This is to prevent cases of admins accidentally preventing mods from moderating according to their own community rules + * Admins can still always explicitly take over communities by making themselves mods, in this way, they are able to handle mod reports for any abandoned communities, etc + + +# Reference-level explanation + +* In the UI, changes are needed for both reporting as well as the reports inbox views +* In the database and API, we should split reports by intended audience +* Federation needs to be changed as well in order to allow distinguishing the report target audience + +# Drawbacks + +It might make reporting slightly more confusing for end users - the mod/admin distinction might not be fully clear to all. + +# Rationale and alternatives + +Alternatively, we could make reporting **even more** granular. It would be possible to allow users to select only a specific instances admins as the intended report audience, for example. +However, I think this has several downsides: +* Makes the report UI even more confusing +* Potentially takes away valuable information from other admins (imagine a user only reports CSAM to their own instances admins, while leaving the offending post authors home admins in the dark) + +# Prior art + +Most other social networks allow users to select whether they are reporting a violation of community rules, or site rules as whole. + +# Unresolved questions + +Does ActivityPub properly support splitting up reports like this? From 2ebea3f5262242ac21d3bf83997d17359320b829 Mon Sep 17 00:00:00 2001 From: Sander Saarend Date: Tue, 20 Feb 2024 12:07:32 +0200 Subject: [PATCH 02/12] Update 0000-report-inboxes.md Minor clarification --- 0000-report-inboxes.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/0000-report-inboxes.md b/0000-report-inboxes.md index 755e7c6..6b4e647 100644 --- a/0000-report-inboxes.md +++ b/0000-report-inboxes.md @@ -5,7 +5,7 @@ # Summary -Rather than combining all reports into a single reprt inbox, we should allow users to select whether they are reporting to mods or admins, and we should split reports into different inboxes based on that selection. +Rather than combining all reports into a single report inbox, we should allow users to select whether they are reporting to mods or admins, and we should split reports into different inboxes based on that selection. # Motivation @@ -18,7 +18,7 @@ The current approach has some shortcomings: # Guide-level explanation -1. Whe creating reports, users are able to select if it's a mod report, or an admin report +1. Whe creating reports, users are able to select if it's a mod report, or an admin report (or both) ![image](https://github.com/sunaurus/lemmy-rfcs/assets/5356547/9a21b527-6c88-4024-b287-3371d77688f4) 2. Instead of the current single report inbox, there will be three different kinds of inboxes: From 8752d60b63dae9069e1e7e4d8ccb7640157f77e3 Mon Sep 17 00:00:00 2001 From: Sander Saarend Date: Tue, 20 Feb 2024 12:10:09 +0200 Subject: [PATCH 03/12] Improve formatting --- 0000-report-inboxes.md | 1 + 1 file changed, 1 insertion(+) diff --git a/0000-report-inboxes.md b/0000-report-inboxes.md index 6b4e647..5611ea6 100644 --- a/0000-report-inboxes.md +++ b/0000-report-inboxes.md @@ -26,6 +26,7 @@ The current approach has some shortcomings: * Mod reports - show all reports sent to mods for any communities the user moderates * All reports - Shows a read-only view of all (admin and mod) reports, only visible to admins * This would allow admins to still keep an eye on mod actions on their instance if they wish + The UI wouldn't need to change for mods, but for admins, there would be a new selection at the top of the reports page (the "mod reports" tab would only be visible if the admin is also a mod in any community): ![image](https://github.com/sunaurus/lemmy-rfcs/assets/5356547/cc4ad68c-6e85-4cd9-b324-131c06951cb3) From a1cdb143b76c1b904e7dd703a028aded40a03109 Mon Sep 17 00:00:00 2001 From: Sander Saarend Date: Tue, 20 Feb 2024 12:14:30 +0200 Subject: [PATCH 04/12] Formatting --- 0000-report-inboxes.md | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/0000-report-inboxes.md b/0000-report-inboxes.md index 5611ea6..ee86810 100644 --- a/0000-report-inboxes.md +++ b/0000-report-inboxes.md @@ -18,26 +18,29 @@ The current approach has some shortcomings: # Guide-level explanation -1. Whe creating reports, users are able to select if it's a mod report, or an admin report (or both) +### When creating reports, users will be able to select if it's a mod report, or an admin report (or both) + ![image](https://github.com/sunaurus/lemmy-rfcs/assets/5356547/9a21b527-6c88-4024-b287-3371d77688f4) -2. Instead of the current single report inbox, there will be three different kinds of inboxes: - * Admin reports - show all reports sent to admins (only visible to admins) - * Mod reports - show all reports sent to mods for any communities the user moderates - * All reports - Shows a read-only view of all (admin and mod) reports, only visible to admins - * This would allow admins to still keep an eye on mod actions on their instance if they wish +### Instead of the current single report inbox, there will be three different kinds of inboxes + +* Admin reports - show all reports sent to admins (only visible to admins) +* Mod reports - show all reports sent to mods for any communities the user moderates +* All reports - Shows a read-only view of all (admin and mod) reports, only visible to admins + * This would allow admins to still keep an eye on mod actions on their instance if they wish The UI wouldn't need to change for mods, but for admins, there would be a new selection at the top of the reports page (the "mod reports" tab would only be visible if the admin is also a mod in any community): ![image](https://github.com/sunaurus/lemmy-rfcs/assets/5356547/cc4ad68c-6e85-4cd9-b324-131c06951cb3) -3. Resolving reports should be more granular - * Reports in the "admin reports" tab can only be resolved for admins of the local instance - * To reduce overhead, **banning reported user on the user's home instance + removing reported content should automatically resolve reports for remote admins as well** - * Reports in the "mod reports" tab can only be resolved by relevant mods. Admins can only reoslve these if they are also explicit mods in the relevant communities. - * To reduve overhead, **banning reported user on the communities instance + removing reported content should automatically resolve reports for mods as well** - * Reports in the "all reports" tab can not be resolved, they are only there for a read-only overview - * This is to prevent cases of admins accidentally preventing mods from moderating according to their own community rules - * Admins can still always explicitly take over communities by making themselves mods, in this way, they are able to handle mod reports for any abandoned communities, etc +### Resolving reports should be more granular + +* Reports in the "admin reports" tab can only be resolved for admins of the local instance + * To reduce overhead, **banning reported user on the user's home instance + removing reported content should automatically resolve reports for remote admins as well** +* Reports in the "mod reports" tab can only be resolved by relevant mods. Admins can only reoslve these if they are also explicit mods in the relevant communities. + * To reduve overhead, **banning reported user on the communities instance + removing reported content should automatically resolve reports for mods as well** +* Reports in the "all reports" tab can not be resolved, they are only there for a read-only overview + * This is to prevent cases of admins accidentally preventing mods from moderating according to their own community rules + * Admins can still always explicitly take over communities by making themselves mods, in this way, they are able to handle mod reports for any abandoned communities, etc # Reference-level explanation From 837f95707a51448618018f753e9477da4c6afc59 Mon Sep 17 00:00:00 2001 From: Sander Saarend Date: Tue, 20 Feb 2024 12:18:02 +0200 Subject: [PATCH 05/12] Update 0000-report-inboxes.md --- 0000-report-inboxes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/0000-report-inboxes.md b/0000-report-inboxes.md index ee86810..e3d61e0 100644 --- a/0000-report-inboxes.md +++ b/0000-report-inboxes.md @@ -36,7 +36,7 @@ The UI wouldn't need to change for mods, but for admins, there would be a new se * Reports in the "admin reports" tab can only be resolved for admins of the local instance * To reduce overhead, **banning reported user on the user's home instance + removing reported content should automatically resolve reports for remote admins as well** -* Reports in the "mod reports" tab can only be resolved by relevant mods. Admins can only reoslve these if they are also explicit mods in the relevant communities. +* Reports in the "mod reports" tab can only be resolved by relevant mods. Admins can only resolve these if they are also explicit mods in the relevant communities. * To reduve overhead, **banning reported user on the communities instance + removing reported content should automatically resolve reports for mods as well** * Reports in the "all reports" tab can not be resolved, they are only there for a read-only overview * This is to prevent cases of admins accidentally preventing mods from moderating according to their own community rules From 6acd78d72d48bf91bec03245adfe2995493bc810 Mon Sep 17 00:00:00 2001 From: Sander Saarend Date: Tue, 20 Feb 2024 12:35:55 +0200 Subject: [PATCH 06/12] Update 0000-report-inboxes.md --- 0000-report-inboxes.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/0000-report-inboxes.md b/0000-report-inboxes.md index e3d61e0..ee5bb56 100644 --- a/0000-report-inboxes.md +++ b/0000-report-inboxes.md @@ -35,9 +35,9 @@ The UI wouldn't need to change for mods, but for admins, there would be a new se ### Resolving reports should be more granular * Reports in the "admin reports" tab can only be resolved for admins of the local instance - * To reduce overhead, **banning reported user on the user's home instance + removing reported content should automatically resolve reports for remote admins as well** + * To reduce overhead, **banning the reported user on the user's home instance + removing reported content should automatically resolve reports for remote admins as well** * Reports in the "mod reports" tab can only be resolved by relevant mods. Admins can only resolve these if they are also explicit mods in the relevant communities. - * To reduve overhead, **banning reported user on the communities instance + removing reported content should automatically resolve reports for mods as well** + * To reduce overhead, **admins banning reported user on the community instance OR the user's home instance + removing reported content should automatically resolve reports for mods as well** * Reports in the "all reports" tab can not be resolved, they are only there for a read-only overview * This is to prevent cases of admins accidentally preventing mods from moderating according to their own community rules * Admins can still always explicitly take over communities by making themselves mods, in this way, they are able to handle mod reports for any abandoned communities, etc From 22493bb8c48802a261fb125f427b93fa2b3dbc44 Mon Sep 17 00:00:00 2001 From: Sander Saarend Date: Tue, 20 Feb 2024 12:36:16 +0200 Subject: [PATCH 07/12] Update 0000-report-inboxes.md --- 0000-report-inboxes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/0000-report-inboxes.md b/0000-report-inboxes.md index ee5bb56..59f4999 100644 --- a/0000-report-inboxes.md +++ b/0000-report-inboxes.md @@ -37,7 +37,7 @@ The UI wouldn't need to change for mods, but for admins, there would be a new se * Reports in the "admin reports" tab can only be resolved for admins of the local instance * To reduce overhead, **banning the reported user on the user's home instance + removing reported content should automatically resolve reports for remote admins as well** * Reports in the "mod reports" tab can only be resolved by relevant mods. Admins can only resolve these if they are also explicit mods in the relevant communities. - * To reduce overhead, **admins banning reported user on the community instance OR the user's home instance + removing reported content should automatically resolve reports for mods as well** + * To reduce overhead, **admins banning the reported user on the community instance OR the user's home instance + removing reported content should automatically resolve reports for mods as well** * Reports in the "all reports" tab can not be resolved, they are only there for a read-only overview * This is to prevent cases of admins accidentally preventing mods from moderating according to their own community rules * Admins can still always explicitly take over communities by making themselves mods, in this way, they are able to handle mod reports for any abandoned communities, etc From 9f76c449e7e798ffc85a38c9b962f0e6bdeedf11 Mon Sep 17 00:00:00 2001 From: Sander Saarend Date: Tue, 20 Feb 2024 12:40:11 +0200 Subject: [PATCH 08/12] Add note about escalating reports --- 0000-report-inboxes.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/0000-report-inboxes.md b/0000-report-inboxes.md index 59f4999..ba173a8 100644 --- a/0000-report-inboxes.md +++ b/0000-report-inboxes.md @@ -42,6 +42,9 @@ The UI wouldn't need to change for mods, but for admins, there would be a new se * This is to prevent cases of admins accidentally preventing mods from moderating according to their own community rules * Admins can still always explicitly take over communities by making themselves mods, in this way, they are able to handle mod reports for any abandoned communities, etc +### Mods should be able to escalate reports to admins + +This would generate a corresponding report in the admin inbox. # Reference-level explanation From 8dd54412efba068b351ac76bf6826b132e86b52d Mon Sep 17 00:00:00 2001 From: Sander Saarend Date: Tue, 20 Feb 2024 12:46:21 +0200 Subject: [PATCH 09/12] Update 0000-report-inboxes.md --- 0000-report-inboxes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/0000-report-inboxes.md b/0000-report-inboxes.md index ba173a8..d5884fb 100644 --- a/0000-report-inboxes.md +++ b/0000-report-inboxes.md @@ -27,7 +27,7 @@ The current approach has some shortcomings: * Admin reports - show all reports sent to admins (only visible to admins) * Mod reports - show all reports sent to mods for any communities the user moderates * All reports - Shows a read-only view of all (admin and mod) reports, only visible to admins - * This would allow admins to still keep an eye on mod actions on their instance if they wish + * This is a read-only version of the current 0.19.3 admin report view, and would allow admins to still keep an eye on mod actions on their instance if they wish The UI wouldn't need to change for mods, but for admins, there would be a new selection at the top of the reports page (the "mod reports" tab would only be visible if the admin is also a mod in any community): ![image](https://github.com/sunaurus/lemmy-rfcs/assets/5356547/cc4ad68c-6e85-4cd9-b324-131c06951cb3) From 928430e722f7496b577214400b811719ef3e52a4 Mon Sep 17 00:00:00 2001 From: Sander Saarend Date: Tue, 20 Feb 2024 18:10:31 +0200 Subject: [PATCH 10/12] Update 0000-report-inboxes.md Incorporate suggestions --- 0000-report-inboxes.md | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/0000-report-inboxes.md b/0000-report-inboxes.md index d5884fb..b8f9a6f 100644 --- a/0000-report-inboxes.md +++ b/0000-report-inboxes.md @@ -22,12 +22,17 @@ The current approach has some shortcomings: ![image](https://github.com/sunaurus/lemmy-rfcs/assets/5356547/9a21b527-6c88-4024-b287-3371d77688f4) +**Note: labels on the sreenshot are illustrative, actual labels can be more user-friendy.** Maybe something like: +* Breaks community rules (report sent to moderators) +* Breaks instance rules (report sent to admins) + ### Instead of the current single report inbox, there will be three different kinds of inboxes -* Admin reports - show all reports sent to admins (only visible to admins) +* Admin reports - show all reports sent to admins (only visible to admins) * Mod reports - show all reports sent to mods for any communities the user moderates -* All reports - Shows a read-only view of all (admin and mod) reports, only visible to admins - * This is a read-only version of the current 0.19.3 admin report view, and would allow admins to still keep an eye on mod actions on their instance if they wish + * This is equivalent to the report view that mods currently have in Lemmy already +* All reports - Shows a view of all (admin and mod) reports, only visible to admins + * This is akin to the current 0.19.3 admin report view, and would allow admins to still keep an eye on mod actions on their instance if they wish The UI wouldn't need to change for mods, but for admins, there would be a new selection at the top of the reports page (the "mod reports" tab would only be visible if the admin is also a mod in any community): ![image](https://github.com/sunaurus/lemmy-rfcs/assets/5356547/cc4ad68c-6e85-4cd9-b324-131c06951cb3) @@ -38,10 +43,9 @@ The UI wouldn't need to change for mods, but for admins, there would be a new se * To reduce overhead, **banning the reported user on the user's home instance + removing reported content should automatically resolve reports for remote admins as well** * Reports in the "mod reports" tab can only be resolved by relevant mods. Admins can only resolve these if they are also explicit mods in the relevant communities. * To reduce overhead, **admins banning the reported user on the community instance OR the user's home instance + removing reported content should automatically resolve reports for mods as well** -* Reports in the "all reports" tab can not be resolved, they are only there for a read-only overview - * This is to prevent cases of admins accidentally preventing mods from moderating according to their own community rules - * Admins can still always explicitly take over communities by making themselves mods, in this way, they are able to handle mod reports for any abandoned communities, etc - +* Admins could still resolve reports in the "all reports" tab + * If it's not an admin report, and not a mod report from a community the admin explicitly moderates, then there should be an additional warning/confirmation when resolving a report here. This is to prevent cases of admins accidentally preventing mods from moderating according to their own community rules. + ### Mods should be able to escalate reports to admins This would generate a corresponding report in the admin inbox. @@ -70,3 +74,7 @@ Most other social networks allow users to select whether they are reporting a vi # Unresolved questions Does ActivityPub properly support splitting up reports like this? + +# Future possibilities + +In the future, it might be a nice addition to have some automation to always escalate to admins, even if they're submitted as mod reports, based on report keywords. For example, "CSAM", "Spam", etc. From 4d5823d2223bbefc9ef96b3a18c1b5cc62ea39b2 Mon Sep 17 00:00:00 2001 From: Sander Saarend Date: Tue, 20 Feb 2024 18:20:24 +0200 Subject: [PATCH 11/12] Update 0000-report-inboxes.md --- 0000-report-inboxes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/0000-report-inboxes.md b/0000-report-inboxes.md index b8f9a6f..f40a025 100644 --- a/0000-report-inboxes.md +++ b/0000-report-inboxes.md @@ -29,7 +29,7 @@ The current approach has some shortcomings: ### Instead of the current single report inbox, there will be three different kinds of inboxes * Admin reports - show all reports sent to admins (only visible to admins) -* Mod reports - show all reports sent to mods for any communities the user moderates +* Mod reports - show all reports sent to mods for any communities the user moderates (visible to admins in case they are explicit mods in any communities) * This is equivalent to the report view that mods currently have in Lemmy already * All reports - Shows a view of all (admin and mod) reports, only visible to admins * This is akin to the current 0.19.3 admin report view, and would allow admins to still keep an eye on mod actions on their instance if they wish From 88af85eb434cd360d76ffe0ec5a425d791a8eea9 Mon Sep 17 00:00:00 2001 From: Sander Saarend Date: Tue, 20 Feb 2024 18:26:40 +0200 Subject: [PATCH 12/12] Update 0000-report-inboxes.md --- 0000-report-inboxes.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/0000-report-inboxes.md b/0000-report-inboxes.md index f40a025..b8359b9 100644 --- a/0000-report-inboxes.md +++ b/0000-report-inboxes.md @@ -39,12 +39,14 @@ The UI wouldn't need to change for mods, but for admins, there would be a new se ### Resolving reports should be more granular -* Reports in the "admin reports" tab can only be resolved for admins of the local instance - * To reduce overhead, **banning the reported user on the user's home instance + removing reported content should automatically resolve reports for remote admins as well** -* Reports in the "mod reports" tab can only be resolved by relevant mods. Admins can only resolve these if they are also explicit mods in the relevant communities. +* Reports in the "admin reports" tab can only be manually resolved for admins of the local instance + * To reduce overhead, **banning the reported user on the user's home instance + removing reported content should automatically resolve reports for remote admins as well**. +* Reports in the "mod reports" tab should be manually resolved by relevant mods (including admins, if they are explicit mods in the relevant community). * To reduce overhead, **admins banning the reported user on the community instance OR the user's home instance + removing reported content should automatically resolve reports for mods as well** * Admins could still resolve reports in the "all reports" tab * If it's not an admin report, and not a mod report from a community the admin explicitly moderates, then there should be an additional warning/confirmation when resolving a report here. This is to prevent cases of admins accidentally preventing mods from moderating according to their own community rules. + +To further clarify automatic resolution of reports: in any case where there is no further action possible, the report should be automatically resolved. ### Mods should be able to escalate reports to admins