Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impl] message validation #1

Open
yudetamago opened this issue Mar 29, 2019 · 4 comments
Open

[Impl] message validation #1

yudetamago opened this issue Mar 29, 2019 · 4 comments

Comments

@yudetamago
Copy link
Contributor

No description provided.

@nrryuya
Copy link
Member

nrryuya commented Apr 7, 2019

Same thought with #4 (comment)

@yudetamago
Copy link
Contributor Author

yudetamago commented Apr 8, 2019

Makes sense, complete validation is not necessary, but some of simplified validations (like justification_is_justified as described above) are useful for debugging.
Specifically, We might use it as just an assertion for experiments like:

res = sender.add_message(message)
assert res.is_ok(), res.value

@yudetamago yudetamago changed the title Implement message validation [Impl] message validation Apr 8, 2019
@yudetamago
Copy link
Contributor Author

yudetamago commented Apr 11, 2019

About justification_is_justified, it is required to check whether the message is to be "pending" or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants