Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Add AOSP Build Files #8

Open
gudenau opened this issue Apr 10, 2018 · 3 comments
Open

[Minor] Add AOSP Build Files #8

gudenau opened this issue Apr 10, 2018 · 3 comments

Comments

@gudenau
Copy link

gudenau commented Apr 10, 2018

I added this project's source to my AOSP build and it does not appear to have the required metadata to build with Android itself, from what I can tell it requires an Android.mk.

@Lanchon
Copy link
Owner

Lanchon commented Apr 10, 2018

so add it! :) it belongs in your directory, not in this repo (unless you can show me why).

@gudenau
Copy link
Author

gudenau commented Apr 11, 2018

In order to be built in a ROM there needs to be a way for the build system to know about the application. There is a little metadata that is put into a Makefile that is checked when building to figure out where everything is and how it is built. This Makefile is part of the source of the application.

@Lanchon
Copy link
Owner

Lanchon commented Apr 11, 2018

This Makefile is part of the source of the application.

no it isn't. this app -as all common android apps- uses the gradle build system, and its repo includes all necessary gradle build scripts. an android-style makefile does not belong in this repo, just like an ant build script or a bazel build file or a GNU makefile don't: because i've chosen gradle.

integration with other build systems (including android's) is your responsibility.

even if you contributed such a makefile i wouldn't merge it, because i won't have stuff in the repo that i don't regularly test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants