Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Config options to disable features when shaders are enabled #248

Open
zndrmn opened this issue Nov 2, 2024 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@zndrmn
Copy link

zndrmn commented Nov 2, 2024

Is your feature request related to a problem? Please describe.
Some shaderpacks add their own handheld lighting which is usually colored. With LambDynamicLights, the colors get overridden by LambDynamicLights which causes the shaderpack to use its default light color (ontop of the original). This will make it so that redstone torches don't glow red for example.

Describe the solution you'd like
Making it so that you can disable some features like handheld lighting or dynamic entity lighting when shaders are detected/enabled would be great! I think it would be important for the user to be able to choose what can and cannot be disabled since some shaderpacks can vary in terms of the features they have, like having dynamic handheld lighting or dynamic entity lighting.

Describe alternatives you've considered
Disabling the whole mod while using shaders. But this can get quite annoying when switching between using shaders and disabling them frequently.

@zndrmn zndrmn added the enhancement New feature or request label Nov 2, 2024
@LambdAurora
Copy link
Owner

These options are already features, hand-held is referred to as "First-person" in the settings:

image

@zndrmn
Copy link
Author

zndrmn commented Nov 2, 2024

Yeah I know, I was wondering if those setting could disable itself automatically when shaders are enabled

@CaoTrongThang
Copy link

@LambdAurora Hi, i think this feature will be good if you can add it, automatically disable "first-hand" when people turn on the shader, really hope you can add this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants