Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jackalope/jackalope-doctrine-dbal #66

Open
kochen opened this issue Oct 17, 2017 · 2 comments
Open

jackalope/jackalope-doctrine-dbal #66

kochen opened this issue Oct 17, 2017 · 2 comments

Comments

@kochen
Copy link

kochen commented Oct 17, 2017

the package is set in the require-dev section, but mentioned in the README as a step you should do.

I'd move it into the suggest section of composer or make it part of the actual requirements and remove it from the steps as it'd be installed with the plugin.

@michalmarcinkowski thoughts?

@michalmarcinkowski
Copy link
Member

I believe it's used by our test suite, so removing it from require-dev would break tests. Have you checked this?

@ElectricMaxxx
Copy link

In general you should requiere phpcr/implementation as an virtual package and then give the user the chance to use dbal or jackrabit. So having it in require-dev is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants