New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThreadLocalUtil natives does not check for errors. #980

Open

xxDark opened this issue May 14, 2024 · 0 comments

Labels

Type: Enhancement

xxDark commented May 14, 2024

Question

Hello. code in question: https://github.com/LWJGL/lwjgl3/blob/master/modules/lwjgl/core/src/main/c/common_tools.h#L60-L82
If for whatever reason initialization of ThreadLocalUtil here fails, VM will silently crash. That was hard to track down. Is there any chance error checking could be added here? Similarly, https://github.com/LWJGL/lwjgl3/blob/master/modules/lwjgl/core/src/main/c/org_lwjgl_system_ThreadLocalUtil.c#L12-L14
Thanks!

xxDark added the Type: Question label

TheMrMilchmann added Type: Enhancement and removed Type: Question labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment