Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activation of air absorption #379

Open
jordanalwon opened this issue Nov 13, 2024 · 0 comments
Open

Activation of air absorption #379

jordanalwon opened this issue Nov 13, 2024 · 0 comments
Assignees
Labels

Comments

@jordanalwon
Copy link

Hi,

i found some discrepancies with the activation of air_absorption:
When using pra.Room.from_corners, the argument air_absorption=True can be set via initialization.
But to activate the air absorption at a different position in code I used the line room.air_absorption = True.
I already know that this is not the correct way to program this. To work properly I should use room.set_air_absorption()
I code on a Windows machine and run CI-tests on a linux server. I noticed room.air_absorption= True runs without an error on windows but raises TypeError: 'bool' object is not subscriptable on linux.

So I would suggest that the variable air_absorption of room should be a property without a setter method to prevent the use of room.air_absorption = True.
And do you have any idea why no error is raised when using Windows?

@fakufaku fakufaku self-assigned this Dec 7, 2024
@fakufaku fakufaku added the bug label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants