Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data dependency on subsequent actions with FailureMode::Allow #159

Open
adam-cattermole opened this issue Dec 5, 2024 · 0 comments
Open

Comments

@adam-cattermole
Copy link
Member

adam-cattermole commented Dec 5, 2024

With the changes in #158 we no longer resume and ignore subsequent actions when an action with FailureMode::Allow fails. This creates an "undesirable" behaviour for some cases.

An example is performing authenticated rate-limiting where the auth service is set to FailureMode::Allow; on failure there is no data returned from the auth service, so if your rate limit action is predicated on data expected from the auth request, or the data is used to determine which limit to apply, the rate limiting would not take place and all requests would "silently" go through.

This can be easily reproduced with the *.a.multi.com example in our test environment https://github.com/Kuadrant/wasm-shim/blob/main/utils/deploy/envoy.yaml#L296-L323, by setting authorino failureMode: allow and scaling down both the authorino-operator and authorino; all requests go through the rate-limiting service and are allowed with 200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant