feat: allow setting custom transformer function as option #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KevFan <[email protected]>
Signed-off-by: KevFan <[email protected]>
KevFan
force-pushed
the
transformer-option
branch
from
99cc672 to
168c27d
Compare
KevFan
added
enhancement
KevFan
commented
Nov 29, 2024
| use ./examples | ||
| use ( | ||
| ./examples | ||
| . |
There was a problem hiding this comment.
Adding the main module was required for me to properly run the example kuadrant in debug mode as otherwise it was not able to find the main module packages for adding break points
KevFan
commented
Nov 29, 2024
Comment on lines
+266
to
+267
| func Restructure[T any](obj any) (any, error) { | ||
| return TransformFunc[T]()(obj) |
There was a problem hiding this comment.
This is probably redundant if we choose to just use TransformFunc everywhere.
Not sure do we want to keep this in general
There was a problem hiding this comment.
I like the idiomatic symmetry of having Restructure and Destruct.
Signed-off-by: KevFan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #40
Allows option to enhance/extend the default transformation applied by watchers when listing objects