Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure fresh build of zcash_client_backend dep in CI #2292

Open
borngraced opened this issue Dec 13, 2024 · 3 comments
Open

ensure fresh build of zcash_client_backend dep in CI #2292

borngraced opened this issue Dec 13, 2024 · 3 comments
Labels
improvement: CI priority: urgent Critical tasks requiring immediate action.

Comments

@borngraced
Copy link
Member

borngraced commented Dec 13, 2024

zcash_client_backend dependency is sometimes fetched from a cached location during CI operations, which leads to error like file not found for module compact_formats in z_coin and causes CI to fail.

I have two possible solutions, which involves running one of these command just before cargo /test/build/test commands

rm -rf ~/.cargo/git/checkouts/librustzcash*

or

cargo update -p zcash_client_backend
Screenshot 2024-12-13 at 15 42 30
@shamardy shamardy added the priority: urgent Critical tasks requiring immediate action. label Dec 13, 2024
@shamardy
Copy link
Collaborator

With this we wouldn't need to remove caching in CI. I was about to remove CI caching, great find!

@dimxy
Copy link
Collaborator

dimxy commented Dec 18, 2024

I saw this issue couple times.
I noticed compact_formats.rs is a generated src by the build.rs. Perhaps build.rs fails to run sometimes, so there is no compact_formats.rs in the .cargo/git/checkouts/librustzcash installation.

BTW the original zcash/librustzcash now has this compact_formats.rs added in the repo.

@borngraced
Copy link
Member Author

I saw this issue couple times. I noticed compact_formats.rs is a generated src by the build.rs. Perhaps build.rs fails to run sometimes, so there is no compact_formats.rs in the .cargo/git/checkouts/librustzcash installation.

BTW the original zcash/librustzcash now has this compact_formats.rs added in the repo.

deleting https://github.com/KomodoPlatform/librustzcash/blob/master/zcash_client_backend/.gitignore could another solution too! cc @dimxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement: CI priority: urgent Critical tasks requiring immediate action.
Projects
None yet
Development

No branches or pull requests

3 participants