Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectionPool does not expose connection errors #158

Open
kilnerm opened this issue Sep 11, 2018 · 0 comments
Open

ConnectionPool does not expose connection errors #158

kilnerm opened this issue Sep 11, 2018 · 0 comments

Comments

@kilnerm
Copy link
Contributor

kilnerm commented Sep 11, 2018

Reported here: Kitura/Swift-Kuery-PostgreSQL#25

I think it would be more user friendly if the ConnectionPool exposed underlying database connection errors to users so they can act upon them.

Currently the only time we expose an issue is where we fail to generate connections upon pool creation.

I don't believe we should fail but we should give users the option to handle errors and choose to fail if that is desirable to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant