Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPStatusCode enum is missing registered values #305

Open
djones6 opened this issue Jul 30, 2019 · 1 comment
Open

HTTPStatusCode enum is missing registered values #305

djones6 opened this issue Jul 30, 2019 · 1 comment

Comments

@djones6
Copy link
Contributor

djones6 commented Jul 30, 2019

The public enum HTTPStatusCode is missing a number of values that are registered with IANA:
https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml

The ones that I spotted are:

  • 423: Locked
  • 425: Too Early
  • 426: Upgrade Required

There may be others missing - it would be worth comparing against the IANA list.

Whilst adding cases to this public enum is technically a breaking change, we do not realistically expect someone to exhaustively switch over it (ie. without a default case), and so we feel this is a reasonable change to make as a bug fix.

This change needs to be made to both Kitura-net and Kitura-NIO.

@djones6 djones6 added this to the 2019.16 milestone Jul 30, 2019
@pushkarnk
Copy link
Contributor

Looks like too early (425) doesn't exist in SwiftNIO's HTTPResponseStatus

@djones6 djones6 removed this from the 2019.16 milestone Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants