Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to only return gene full text search results that have data #89

Open
jonrkarr opened this issue May 23, 2020 · 2 comments
Open
Labels
enhancement New feature or request future

Comments

@jonrkarr
Copy link
Member

Example:

@jonrkarr jonrkarr added the bug Something isn't working label May 23, 2020
@lzy7071
Copy link
Contributor

lzy7071 commented May 23, 2020

I think this is a similar problem with whether to display proteins with no abundance data. Essentially, it's a question of if we should display genes with no

  1. Proteins with associated abundance information.
    AND
  2. RNA or protein modification information.

We do, however, have information regarding the KEGG group.

Additionally, we won't know if there is RNA modification data until we step into the gene-specific page due to limitations with multi-index ftx. But there may be a workaround

@jonrkarr jonrkarr added enhancement New feature or request and removed bug Something isn't working labels May 24, 2020
@jonrkarr
Copy link
Member Author

Upon further reflection, I think its informative for Datanator to communicate to users that we don't have data about a specific KO group. This is clearer not being able to render a page for the KO group at all.

As we have discussed previously (KarrLab/datanator_frontend#155), it would be nice to make full text search results with no data optional. As part of this, we would need to add a UI element to the search results page to let users toggle the option. This isn't critical. Lets focus on finishing debugging and come back to this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request future
Projects
None yet
Development

No branches or pull requests

2 participants