Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Mpris Properties #811

Closed
1 task done
Batwam opened this issue Oct 15, 2023 · 7 comments
Closed
1 task done

Missing Mpris Properties #811

Batwam opened this issue Oct 15, 2023 · 7 comments
Labels
bug Something isn't working Linux Linux related issue

Comments

@Batwam
Copy link

Batwam commented Oct 15, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Currently, the app doesn't appear to provide the DesktopEntry and Identity information as part of the Mpris data it is giving. Extensions relying on this info display blank info. See below, info correctly provided by the Spotify app:
image

image

On the other hand, Spotube doesn't provide these properties:
image

Expected Behavior

Please add Identity 'Spotube' and DesktopEntry 'Spotube to the list of Mpris properties.

Steps to reproduce

open the app
check mpris data using a D-Bus inspection app like D-Feet.

Operating System

Linux

Spotube version

v3.1.2

Installation source

Flathub (Flatpak)

Additional information

No response

@Batwam Batwam added the bug Something isn't working label Oct 15, 2023
@KRTirtho
Copy link
Owner

@Batwam
Copy link
Author

Batwam commented Oct 15, 2023

Thanks for the quick response! This is quite strange then, I wonder why the info is not getting recognised... for clarity, the rest (play/pause, metadada, album cover,...) all work fine.

By the way, desktopEntry is meant to be the part of the filename before .desktop, not the path so it should be something like spotube. See spec here: https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry

Example: The desktop entry file is "/usr/share/applications/vlc.desktop", and this property contains "vlc"

@Batwam
Copy link
Author

Batwam commented Oct 15, 2023

Could it be because Identity and DesktopEntry are meant to be Properties and not Methods?

I checked using dbus-send. Spotify returns the value, spotube doesn't:
image

@Batwam
Copy link
Author

Batwam commented Oct 15, 2023

I'm just noticing that these Properties are meant to be part of org.mpris.MediaPlayer2 Interface which doesn't appear to exist for spotube. Only org.mpris.MediaPlayer2.Player is listed.

Is there anything I could do on my end to check what might be going on?

@Batwam Batwam changed the title Missing Mpris Proerties Missing Mpris Properties Oct 16, 2023
@KRTirtho KRTirtho added the Linux Linux related issue label Oct 16, 2023
@KRTirtho
Copy link
Owner

Fixed in e29cc25

@KRTirtho KRTirtho moved this to Done in Spotube Board Oct 16, 2023
@Batwam
Copy link
Author

Batwam commented Oct 16, 2023

amazing, looking forward to the next release!

@KRTirtho KRTirtho moved this from Done to Deployed in Spotube Board Oct 18, 2023
@github-project-automation github-project-automation bot moved this from Deployed to Done in Spotube Board Oct 18, 2023
@KRTirtho KRTirtho moved this from Done to Deployed in Spotube Board Oct 18, 2023
@Batwam
Copy link
Author

Batwam commented Oct 19, 2023

I can confirm that this is now working fine with v3.2.0
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Linux Linux related issue
Projects
Status: Deployed
Development

No branches or pull requests

2 participants