Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recordings download and timezones #55

Closed
HausnerR opened this issue May 5, 2023 · 5 comments
Closed

Recordings download and timezones #55

HausnerR opened this issue May 5, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@HausnerR
Copy link

HausnerR commented May 5, 2023

Hello,
I tried to download recordings using script attached to repo - works well until I want to download most up to date recordings which gives me:

Converting /media/2023-05-05 12_17_28-2023-05-05 12_18_40.mp4...                    
Converting /media/2023-05-05 12_21_37-2023-05-05 12_22_55.mp4...                    
Converting /media/2023-05-05 12_23_18-2023-05-05 12_25_09.mp4...          11          
Converting /media/2023-05-05 12_25_47-2023-05-05 12_27_38.mp4...          11          
Recording in progress /media/2023-05-05 12_39_01-2023-05-05 12_40_41.mp4...          
Recording in progress /media/2023-05-05 12_43_47-2023-05-05 12_45_32.mp4...          
Recording in progress /media/2023-05-05 12_46_24-2023-05-05 12_47_40.mp4...          
Recording in progress /media/2023-05-05 12_52_02-2023-05-05 12_53_11.mp4...          
Recording in progress /media/2023-05-05 12_58_03-2023-05-05 12_59_46.mp4...          
Recording in progress /media/2023-05-05 13_03_31-2023-05-05 13_05_25.mp4...          
Recording in progress /media/2023-05-05 13_05_52-2023-05-05 13_07_18.mp4...          
Recording in progress /media/2023-05-05 13_10_05-2023-05-05 13_12_13.mp4...          
Recording in progress /media/2023-05-05 13_14_29-2023-05-05 13_15_38.mp4...          
Recording in progress /media/2023-05-05 13_19_13-2023-05-05 13_20_22.mp4...          
Recording in progress /media/2023-05-05 13_25_17-2023-05-05 13_26_26.mp4...          
bd8ebebf5524:/config/scripts# date
Fri May  5 14:32:24 CEST 2023
bd8ebebf5524:/config/scripts# date -u
Fri May  5 12:34:19 UTC 2023

Looks like timezone problem?
@JurajNyiri JurajNyiri added the bug Something isn't working label May 5, 2023
@JurajNyiri
Copy link
Owner

JurajNyiri commented May 5, 2023 •
edited
Loading

Yep, related to JurajNyiri/HomeAssistant-Tapo-Control#317.

We can probably fix this by utilising newly introduced self.getTimeCorrection().

I am currently busy with other work, this should be an easy fix though. This needs to be adjusted according to time correction.

@HausnerR
Copy link
Author

HausnerR commented May 5, 2023

Thanks for info!

@HausnerR HausnerR closed this as not planned Won't fix, can't repro, duplicate, stale May 5, 2023
@JurajNyiri JurajNyiri reopened this May 5, 2023
@JurajNyiri
Copy link
Owner

We can keep this open, it is a bug in the lib. Feel free to open PR if you feel like fixing it :-)

@HausnerR
Copy link
Author

HausnerR commented May 5, 2023

I don't feel good enough in Python to handle that :)

@JurajNyiri
Copy link
Owner

@HausnerR should be fixed now. There is one new parameter to constructor of download class. See example script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HausnerR @JurajNyiri