Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ADMM is never converged #91

Open
JakobAsslaender opened this issue Aug 13, 2024 · 3 comments
Open

[Bug] ADMM is never converged #91

JakobAsslaender opened this issue Aug 13, 2024 · 3 comments

Comments

@JakobAsslaender
Copy link
Member

@nHackel:

I am not sure if I am overlooking something, but you changed the output of the ADMM converged function to always return false:

I presume this is a bug and should be reverted to return true after the for loop, if it gets there, right?

@nHackel
Copy link
Member

nHackel commented Aug 13, 2024

Oh yes, that is definitely not intentional 🙈

@nHackel
Copy link
Member

nHackel commented Aug 13, 2024

I'll fix that on the master real quick

nHackel added a commit that referenced this issue Aug 13, 2024
@nHackel
Copy link
Member

nHackel commented Aug 13, 2024

Maybe we should add convergence tests. Just a small problem with an "excessive" number of iterations and then we check afterwards if it converged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants