We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@nHackel:
I am not sure if I am overlooking something, but you changed the output of the ADMM converged function to always return false:
converged
false
RegularizedLeastSquares.jl/src/ADMM.jl
Line 284 in 06c8405
I presume this is a bug and should be reverted to return true after the for loop, if it gets there, right?
true
The text was updated successfully, but these errors were encountered:
Oh yes, that is definitely not intentional 🙈
Sorry, something went wrong.
I'll fix that on the master real quick
Fix issue #91
ce6af00
Maybe we should add convergence tests. Just a small problem with an "excessive" number of iterations and then we check afterwards if it converged
No branches or pull requests
@nHackel:
I am not sure if I am overlooking something, but you changed the output of the ADMM
converged
function to always returnfalse
:RegularizedLeastSquares.jl/src/ADMM.jl
Line 284 in 06c8405
I presume this is a bug and should be reverted to return
true
after the for loop, if it gets there, right?The text was updated successfully, but these errors were encountered: