-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
map is broken, includeing missing collect_similar for DiskGenerator #144
Comments
I'm keen to try my very old idea of caching a whole column of chunks for (As in your full band iteration - it works fine if we have the whole column) |
Won't this very easily lead to Out-Of-Memory errors for large multi-dimensional arrays where you just can not keep all chunks along the first dimension in memory? Very easy to construct examples where this fails. Another option might just be to completely deprecate |
Does It just seems to me that we are silently returning the wrong answer for map currently, which is worse than OOM errors. I am really keen to not silently return the wrong result ever. We could always fall back to loading partial chunks if the whole column is too large for memory. |
Is this resolve by #198 ? |
Yes, I just tried the example from ArchGDAL, and it seems like it is correct: issetequal(filter(!(==(-9999)), collect(o)), filter(!(==(9999)), o)) # true so this should be working now. |
The
DiskGenerator
is missing an implementation ofcollect_similar
which makes the filter function not work properly. See yeesian/ArchGDAL.jl#409 for the details.The text was updated successfully, but these errors were encountered: