-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added pretty printing for config, indexer, searcher #39
base: main
Are you sure you want to change the base?
Conversation
@codetalker7 review ? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 56.93% 57.23% +0.30%
==========================================
Files 16 16
Lines 699 739 +40
==========================================
+ Hits 398 423 +25
- Misses 301 316 +15 ☔ View full report in Codecov by Sentry. |
A minor thing about tests: can you also add some simple tests which just call the |
i struggled with the tests a bit, would you mind taking a look? |
makes it much easier to inspect the objects than the default printing which dumps all fields at once.