Use UnsafeAtomics 0.3 #709
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Simple pxlth@Tower:~/.julia/dev/AMDGPU$ jl t.jl
Precompiling AMDGPU...
1 dependency successfully precompiled in 9 seconds. 124 already precompiled.
ERROR: LoadError: InvalidIRError: compiling MethodInstance for ker!(::AMDGPU.Device.ROCDeviceVector{Float32, 1}) resulted in invalid LLVM IR
Reason: unsupported call to an unknown function (call to ijl_get_nth_field_checked)
Stacktrace:
[1] indexed_iterate
@ ./namedtuple.jl:172
[2] multiple call sites
@ unknown:0
Reason: unsupported call to an unknown function (call to jl_f_tuple)
Stacktrace:
[1] indexed_iterate
@ ./namedtuple.jl:172
[2] multiple call sites
@ unknown:0
Reason: unsupported call to an unknown function (call to ijl_get_nth_field_checked)
Stacktrace:
[1] atomic_pointermodify
@ ~/.julia/packages/UnsafeAtomics/y7d6Q/ext/UnsafeAtomicsLLVM/atomics.jl:276
[2] modify!
@ ~/.julia/packages/UnsafeAtomics/y7d6Q/ext/UnsafeAtomicsLLVM/internal.jl:23
[3] modify!
@ ~/.julia/packages/UnsafeAtomics/y7d6Q/src/core.jl:11
[4] modify!
@ ~/.julia/packages/Atomix/2spi2/src/core.jl:33
[5] ker!
@ ~/.julia/dev/AMDGPU/t.jl:5
Reason: unsupported dynamic function invocation (call to atomic_pointerreplace)
Stacktrace:
[1] atomic_pointermodify
@ ~/.julia/packages/UnsafeAtomics/y7d6Q/ext/UnsafeAtomicsLLVM/atomics.jl:276
[2] modify!
@ ~/.julia/packages/UnsafeAtomics/y7d6Q/ext/UnsafeAtomicsLLVM/internal.jl:23
[3] modify!
@ ~/.julia/packages/UnsafeAtomics/y7d6Q/src/core.jl:11
[4] modify!
@ ~/.julia/packages/Atomix/2spi2/src/core.jl:33
[5] ker!
@ ~/.julia/dev/AMDGPU/t.jl:5 |
|
I guess I shouldn't have removed that code xD Can you open a PR that re-adds it and adds a test? |
|
Yeah, will do in a bit |
|
Thanks Anton! |
|
Can you run the tests again? I am travelling right now without access to GPUs :) |
|
Yeah, they all pass now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.