Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Manifest-v*.*.toml to default gitignore #462

Open
oxinabox opened this issue Feb 13, 2024 · 1 comment · May be fixed by #477
Open

add Manifest-v*.*.toml to default gitignore #462

oxinabox opened this issue Feb 13, 2024 · 1 comment · May be fixed by #477

Comments

@oxinabox
Copy link
Collaborator

I think this makes sense.
If we are ignoring Manifest.toml by default we should also ignore the Manifest-v*.*.toml that are introduced by JuliaLang/julia#43845
OTOH one does not create these by accident -- they do have to be created via manual rename. So maybe we should leave it to the user?
@gdalle
Copy link
Collaborator

gdalle commented Feb 13, 2024

I would agree with adding them

@frankebel frankebel linked a pull request Jul 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: ignore all Manifest files frankebel/PkgTemplates.jl
2 participants
@oxinabox @gdalle