You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here are a few areas I'm thinking of to improve DomainSets. I'm linking to existing issues.
Factor out the map code. It has no place in this package, and there is a lot of overlap with other packages. The main motivation originally for writing new code was to allow rectangular maps, which you need to map e.g. from 1D to 3D. At the time most existing packages assume that maps are invertible, square or both. (Factor out Map's #92, Don't export jacobian #87)
Write documentation. Even the basic syntax for primitives is not documented. The mechanism of associating domains with canonical domains is very versatile and potentially useful if it were known how to use it (Write documentation #101)
Avoid type piracy. A lot has improved already, but there are some remnants of operators from Base and LinearAlgebra being overloaded simply because they look nice. This will likely take another breaking release, but it should be done. (arithmetic operations with broadcasting #148, Don't use ×? #67)
Come up with a good implementation of approximate in (or approx_in), using atol and rtol arguments. It's important to get this right, since we've been so careful about distinguishing between open and closed domains as well. (use atol and rtol in approx_in #124)
Implement fewer concrete domains. We've been using IntervalSets for intervals. I'm reluctant to expand the implementation of simplices and hyperfaces because other packages already do this, both better and with more focus. (Support hyperfaces #100, Should boundary(::Rectangle) use simpler types? #142)
I've been playing with a DomainSetsCore package, but I don't think it is essential to move forward so it's not on the list.
Ideally, these improvements make DomainSets smaller and yet more functional.
The text was updated successfully, but these errors were encountered:
Update: the first item (factoring out maps) is largely done. All map code now lives in a submodule FunctionMaps.jl, which has its own test suite and could turn into a separate package. For now, everything is backwards compatible (or so it should be) and the internal change happened in v0.7.10.
Here are a few areas I'm thinking of to improve DomainSets. I'm linking to existing issues.
jacobian
#87)approx_in
), usingatol
andrtol
arguments. It's important to get this right, since we've been so careful about distinguishing between open and closed domains as well. (use atol and rtol in approx_in #124)I've been playing with a DomainSetsCore package, but I don't think it is essential to move forward so it's not on the list.
Ideally, these improvements make DomainSets smaller and yet more functional.
The text was updated successfully, but these errors were encountered: