Errors in article 2020/Skeletal-Animation

[elmarsan]

Couple of things I've notice:

• This method signature is wrong: void ExtractBoneWeightForVertices(std::vector& vertices, aiMesh* mesh, const aiScene* scene) The first parameter should be: std::vector<Vertex>&
• The snippet of code to be added in setupMesh contains couple of minor errors:

class Mesh
{
    ...
    
    void setupMesh()
    {
        ....

        // FIX
        // The last vertex attribute at this point if the number 4. (Bitangent)
        // So next attributes should be 5 and 6 respectively.
        
        //  ids
        glEnableVertexAttribArray(3);
        glVertexAttribIPointer(3, 4, GL_INT, sizeof(Vertex), (void*)offsetof(Vertex, m_BoneIDs));

        // weights
        glEnableVertexAttribArray(4);
        glVertexAttribPointer(4, 4, GL_FLOAT, GL_FALSE, sizeof(Vertex), 
            (void*)offsetof(Vertex, m_Weights));   
  
        ...
    }    
    ...
}

[elmarsan]

Another one:

• In the article and code snippets you can find heirarchy rather than Hierarchy

[elmarsan]

Wrong method name (Related with previous one):

• ReadHeirarchyData -> ReadHierarchyData

[elmarsan]

Qualified name is not allowed in method declaration:

• Bone class is header based, hence this method is wrong: glm::mat4 Bone::InterpolateScaling(float animationTime), the correct version is: glm::mat4 InterpolateScaling(float animationTime)

[elmarsan]

Qualified name is not allowed in method declaration:

• Bone class is header based, hence this method is wrong: glm::mat4 Bone::InterpolateScaling(float animationTime), the correct version is: glm::mat4 InterpolateScaling(float animationTime)

Same is happening in Animator header class, all methods are using the qualified name.

[elmarsan]

• Vertex shader snippet uses 430 core version

[elmarsan]

• Animation class doesn't need default constructor

[elmarsan]

• Animation empty destructor

[elmarsan]

• Extra code in Animation constructor

Animation(const std::string& animationPath, Model* model)
	{
		Assimp::Importer importer;
		const aiScene* scene = importer.ReadFile(animationPath, aiProcess_Triangulate);
		assert(scene && scene->mRootNode);
		auto animation = scene->mAnimations[0];
		m_Duration = animation->mDuration;
		m_TicksPerSecond = animation->mTicksPerSecond;
                // Redundant line
		aiMatrix4x4 globalTransformation = scene->mRootNode->mTransformation;
                // Redundant line
		globalTransformation = globalTransformation.Inverse();
		ReadHierarchyData(m_RootNode, scene->mRootNode);
		ReadMissingBones(animation, *model);
	}