We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For some reason I was going through sphere code, and I found that there's a minor error.
Here's how the positions are generated:
LearnOpenGL/src/6.pbr/1.1.lighting/lighting.cpp
Lines 265 to 271 in 3e94252
Here's how the indices for the triangle strips were generated:
Lines 284 to 302 in 3e94252
However this does not work when X_SEGMENTS != Y_SEGMENTS. It currently only works because x and y are interchangeable.
X_SEGMENTS != Y_SEGMENTS
let X_SEGMENTS=32 we get the following result:
I'm a big fan of this website and I hope it gets better in the future. I hope this issue helps.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
For some reason I was going through sphere code, and I found that there's a minor error.
Here's how the positions are generated:
LearnOpenGL/src/6.pbr/1.1.lighting/lighting.cpp
Lines 265 to 271 in 3e94252
Here's how the indices for the triangle strips were generated:
LearnOpenGL/src/6.pbr/1.1.lighting/lighting.cpp
Lines 284 to 302 in 3e94252
However this does not work when
X_SEGMENTS != Y_SEGMENTS
. It currently only works because x and y are interchangeable.let X_SEGMENTS=32 we get the following result:
I'm a big fan of this website and I hope it gets better in the future. I hope this issue helps.
The text was updated successfully, but these errors were encountered: