Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are we asserting string? #11

Open
haylinmoore opened this issue Oct 1, 2020 · 3 comments
Open

Why are we asserting string? #11

haylinmoore opened this issue Oct 1, 2020 · 3 comments

Comments

@haylinmoore
Copy link
Contributor

Why does each function have assert string at the top of it? We are already using typescript so nobody will be able to pass non string variables for validation.

@SuperC03
Copy link
Contributor

SuperC03 commented Oct 8, 2020

Someone could easily apply // @ts-ignore above the function call to bypass the typechecking and break the program.

@haylinmoore
Copy link
Contributor Author

If someone uses tsignore that's their fault imo

@Bunlong
Copy link
Collaborator

Bunlong commented Oct 10, 2020

@hamptonmoore @SuperC03 Could you please make a PR to delete it? Thanks!

haylinmoore added a commit to haylinmoore/validate that referenced this issue Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants