Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt graphql-config format #17

Closed
schickling opened this issue Aug 6, 2016 · 5 comments
Closed

Adapt graphql-config format #17

schickling opened this issue Aug 6, 2016 · 5 comments
Labels

Comments

@schickling
Copy link

Would you consider making the project comply to the graphql-config format?

The goal is the simplify and unify the way people configure their development tools for their GraphQL endpoint/schema.

@jimkyndemeyer
Copy link
Collaborator

Hi Johannes.

As promised, I've emailed you my thoughts. My recommendation is as follows:

The JSON shape of request, and file in graphql.config.json is unlikely to change. I think this standardized shape should be the thing that various projects agree upon, since they can have various other technical requirements and preferences. A small github repo documenting the shape should do the trick.

So, if .graphqlrc is able to reference a graphql.config.json file, or any other compliant file, things can work together. I'll leave the naming of the property up to you. Maybe something like:

{
 "require": "./graphql.config.json"
}

Best regards,
Jim.

@jimkyndemeyer
Copy link
Collaborator

Closing this issue. Will create a new issue when the technical details have been worked out.

@dlindenkreuz
Copy link

@jimkyndemeyer What's the status of this? This feature would be much appreciated.

@schickling
Copy link
Author

@jimkyndemeyer I'd love to pick up the ball on this one again. Would you be open for a collaboration? 🙂

@jimkyndemeyer
Copy link
Collaborator

@schickling Yeah, still open to collaborate on this. Unfortunately I don't have any free time to work on features for this project the next three months due to personal commitments.

In the meantime, I'd like to see kamilkisiela/graphql-config#20 resolved. The reason I'd like that issue resolved is that it's a breaking change, and we'd need to figure out a migration path for plugin users. This also ties into the work @asiandrummer is doing on integrating the GraphQL language service with the plugin.

Finally, Relay Modern support provides even more value for developers, so that has higher priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants