Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unassigned bartender consumption form access with assign_tenders enabled #113

Open
FrankvanMourik opened this issue Feb 22, 2023 · 0 comments

Comments

@FrankvanMourik
Copy link
Contributor

In the current implementation, when the assign_tenders boolean is True for an organization, all bartenders (either assigned or unassigned) can see the buttons to open POS&DCF. The logic used for rendering this button is:

{% if e in events_tending or request.organization == e.organizer and request.organization.assigns_tenders and is_tender %}

We propose an improvement that only assigned bartenders and organization managers can see the buttons. So that would change the rendering logic to:
{% if e in events_tending or request.organization == e.organizer and request.organization.assigns_tenders and is_manager %} where is_manager checks whether the user is a manager of e.organizer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant