Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant warning on sign_alg deprecation in saml_frontend #478

Open
szabogyula opened this issue Nov 28, 2024 · 0 comments
Open

Constant warning on sign_alg deprecation in saml_frontend #478

szabogyula opened this issue Nov 28, 2024 · 0 comments

Comments

@szabogyula
Copy link
Contributor

You can't make good enough configuration to eliminate the next warning in logs:

[WARNING] [satosa.frontends.saml2._handle_authn_response] sign_alg and digest_alg are deprecated; instead, use signing_algorithm and digest_algorithm under the service/idp configuration path (not under policy/default).

Code Version

8.4.0

Expected Behavior

Does not drop this warning

Current Behavior

Drops the warning

Possible Solution

The sign_alg_attr and digest_alg_attr variables always get a value here:

https://github.com/IdentityPython/SATOSA/blob/master/src/satosa/frontends/saml2.py#L408

and that is why this comparsion always true:

https://github.com/IdentityPython/SATOSA/blob/master/src/satosa/frontends/saml2.py#L454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant