Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

create_from_config_file was removed in tag 2.1.4 #65

Open
joe-jordan opened this issue Apr 11, 2022 · 6 comments
Open

create_from_config_file was removed in tag 2.1.4 #65

joe-jordan opened this issue Apr 11, 2022 · 6 comments

Comments

@joe-jordan
Copy link

oidcrp.configure.create_from_config_file() was commented out in a recent commit, and published onto PyPI.

This broke production code, as we point our customers at pip as they install, and pull in new minor versions!

Could you please clarify if it was intentional, and in which case what is the replacement mechanism for loading config from files (I can't find a Release Notes for 2.1.4 which explains this)?

If you will fix this urgently and publish to PyPI, then we won't need to take any action, but if not we will need to patch our software to only accept versions <2.1.4 until it is resolved (by migration to a new implementation or by a fix.)

Thank you.

@rohe
Copy link
Contributor

rohe commented Apr 11, 2022

I'll have a look at this after lunch.

You should consider moving from oidcrp to idpy-oidc.
For several reasons we decided to merge oidcmsg, oidcrp and oidc-op into one package named idpy-oidc.

We will continue to fix bugs in oidcrp but all the major development work will happen in idpy-oidc.

@rohe
Copy link
Contributor

rohe commented Apr 11, 2022

I should write a document describing what you need to do to move.
I would be happy to discuss this with you.

@joe-jordan
Copy link
Author

I will look into migrating in a future release, but we still need a solution for the released versions. Thank you for taking a look.

@rohe
Copy link
Contributor

rohe commented Apr 11, 2022

The reason create_from_config_file was removed from OidcRP was that it's duplicated code to what's in oidcmsg.configure.create_from_config_file() .
Part of a clean up.

@joe-jordan
Copy link
Author

OK, thank you.

I will roll back our released versions to the last compatible version, and then await a migration guide. Will you update this issue later when that documentation is ready? or should I subscribe to something else?

@rohe
Copy link
Contributor

rohe commented Apr 11, 2022

I can place a message here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants