Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not count closing projects as open #981

Open
odeimaiz opened this issue Jun 9, 2023 · 2 comments
Open

Do not count closing projects as open #981

odeimaiz opened this issue Jun 9, 2023 · 2 comments
Assignees
Labels
Feedback Feedback through frontend type:enhancement Feature requests (functionality and UI)

Comments

@odeimaiz
Copy link
Member

odeimaiz commented Jun 9, 2023

If the number of maximum open projects is set to one, after going back to the dashboard, users need to wait for the project to be closed before being able to open another one.

@odeimaiz odeimaiz added type:bug Issue that prevents to perform a certain task, features that don't work as t Feedback Feedback through frontend labels Jun 9, 2023
@sanderegg sanderegg added this to the Watermelon milestone Jun 13, 2023
@sanderegg sanderegg added enhancement and removed type:bug Issue that prevents to perform a certain task, features that don't work as t labels Jun 13, 2023
@sanderegg
Copy link
Member

sanderegg commented Jun 13, 2023

After some thoughts I think this might be an issue:

I guess we could say that a closing study does not count as an "open study" that is fair.
But what if it fails to stop? that means the resources are still in use and you can block the whole system. This is equivalent to this issue: #836
@odeimaiz @mguidon @pcrespov @matusdrobuliak66 @GitHK

I would propose to postpone this in favor of the state zip/unzip disabling and see from there if this is still a showstopper.

points:

  1. It's annoying for the user to wait for the project to close, it can potentially fail.
  2. removing the limit can potentially allow a user to open/close several projects and block the whole platform (i.e. other users) because it uses the resources for nothing (and closing can also potentially fail)
  3. is s4l full limited to 1 project per user?
  4. progress for closing the project?
  5. disable zipping of state should improve speed when closing a project
  6. have a separate counter for max allowed opened/closing projects

@odeimaiz
Copy link
Member Author

I do believe that from a user's perspective this is a bug. Same goes for #846.

@elisabettai elisabettai added type:enhancement Feature requests (functionality and UI) and removed enhancement labels Aug 31, 2023
@sanderegg sanderegg removed this from the Watermelon milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback Feedback through frontend type:enhancement Feature requests (functionality and UI)
Projects
None yet
Development

No branches or pull requests

5 participants