Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Header Component + Routing Searches Component #319

Open
jonatanvicente opened this issue Mar 29, 2023 · 0 comments
Open

Refactoring Header Component + Routing Searches Component #319

jonatanvicente opened this issue Mar 29, 2023 · 0 comments
Assignees
@rociomarchetti
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jonatanvicente
Copy link
Collaborator

jonatanvicente commented Mar 29, 2023 •
edited
Loading

Es necesario refactorizar header.component.

  • La construcción del componente tiene poco sentido, haciéndose un diseño semi-configurable muy pobre. Es necesario hacer la construcción estática.
  • Es necesario revisar el routing del componente Searches. Al estar embebidas todas las búsquedas, no se actualiza la ruta, y resulta imposible pasar parámetros o redireccionar cuando corresponde (p.ej. botón atrás del navegador, o renovación de búsqueda).
@jonatanvicente jonatanvicente converted this from a draft issue Mar 29, 2023
@jonatanvicente jonatanvicente added the enhancement New feature or request label Mar 29, 2023
@jonatanvicente jonatanvicente changed the title Refactoring Header Component Refactoring Header Component + Rounting Searches Component Mar 29, 2023
@jonatanvicente jonatanvicente added the help wanted Extra attention is needed label Mar 29, 2023
@jonatanvicente jonatanvicente changed the title Refactoring Header Component + Rounting Searches Component Refactoring Header Component + Routing Searches Component Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rociomarchetti rociomarchetti

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Business Assistant BCN - Frontend Sprint Backlog
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonatanvicente @rociomarchetti