-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include latest changes in this repository #1
Comments
Hi gqzomer. I'm not sure what you're missing or if you've even got the latest version. The pull request for Mixxx is still pending and afair the reloop_mixage repo is VERY different to this one (I should probably archive this one). See the pull request for docs -> preview too. I tried to map the controller as faithful to the its documentation as possible with Mixxx. Tell me what's not working for you... |
Plus I would welcome improvements, but make sure you've got the latest version. Maybe it is also a good idea to pull-request on the reloop_mixage forks (don't forget the docs). Shall I invite you as a collaborator to my forks? |
I used to the mapping from the reloop_mixage request you mentioned and it worked for me without any issues so no problems there. I am currently working on a few improvements and additions to the mapping. For now I made the following changes
I also plan to eventually add support for decks 3 and 4 by using the midi channel switch on the back of the controller once I finalized the other changes and cleaned up the code. I believe this should be nothing more than a copy and paste of the xml mappings and change in the midi opcode for channel 3 and 4. If you are willing to collaborate on improving the mappings I'm up for it |
Sounds great.
Sounds good too. I was too lazy to do that...
There is already a config option to maximize the library when turning the Trax button. Not moving the Trax button or selecting a track into a deck minimizes the library. The delay is adjustable.
Great!
I'm still struggling with two decks :D but yeah. Why not.
Sure! Make sure you don't break anything, the pull request checks are successful (JS checks etc.) and document your changes in the manual for everybody (Syntax checks there too). |
Great I'll start working on merging the changes into a pull request. For now you can already test the changes I made by using the new mappings in the fork of this repo here.
In my current mapping I removed the logic to automaximize the library since I added the double press feature. But there should be no issues implementing both features side by side. I hope to open a pull request with all the changes soon enough. |
I'm not sure if I've come across correctly: Please fork my fork of the Mixxx repo and my fork of the manuals repo. This here repo is outdated. Don't use that code! That's what I wrote earlier. I've invited you to the repos I mentioned to collaborate. |
I think I didn't communicate clearly that I intent to open a pull request on the forks you mentioned. I just linked to a fork of this repo which I have been using during development of the changes. I was orginally planning on making a new branch our your fork of the mixxx repo (in-fact I already created the |
The I just wanted to make sure you don't waste your time tinkering with this repo 👍 |
I have finalized all my changed and created a pull request on the |
I got lots of stuff to do this week and a party coming up next weekend where I want to apply my limited DJ skills ;). I'll check out the pull request next week, if that's ok with you. |
No worries, the changes in the pull request are quite substancial so take the time you need to review them |
I was looking for a mixxx mapping for my reloop mixage and found this repository. I thought you laid a pretty good foundation but found that some features like the search/scratch mode of the jog wheels were not working quite right. To address this and make some further improvements I made a fork in the hopes of contributing to the mapping you created. Only to find out later that you continued working to improve the mapping in a fork of the mixxx repository found here. Maybe you can update this repo to include the later changes you made or link to the repo you forked in the readme. Currently this is repo is one of the first results when you google 'mixxx reloop mixage mappings'.
Im currently still working on expanding the effect controls and support for controlling deck 3 and 4 with the reloop mixage. Should I make a pull request on this repo or instead make pull request on your reloop_mixage fork?
The text was updated successfully, but these errors were encountered: