Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serverprofile): add force param to serverprofile creation #403

Merged
merged 1 commit into from
Nov 9, 2023
Merged

feat(serverprofile): add force param to serverprofile creation #403

merged 1 commit into from
Nov 9, 2023

Conversation

FalcoSuessgott
Copy link

@FalcoSuessgott FalcoSuessgott commented Nov 6, 2023

This PR introduces the feature to specifiy the force flag for the server profile creation:

https://techlibrary.hpe.com/docs/enterprise/servers/oneview5.0/cicf-api/en/index.html#rest/server-profiles

**force**
Comma-separated list of flags for ignoring specific warnings. Calls may use "all" (or "true") to pass all ignore flags, or "none" (or "false") to pass none of them. Quotes are optional. The supported comma-separated list of flags are:

ignoreSANWarnings: When provided, the operation will ignore warnings for non-critical issues detected in the SAN storage configuration. 
ignoreServerHealth: When provided, the operation will ignore the check to verify that the selected server's health is OK. 
ignoreLSWarnings: When provided, the operation will ignore the validation warnings from local storage.

This is needed in order to fix HewlettPackard/terraform-provider-oneview#548 in the oneview terraform provider.

LMK what you think :)

@nabhajit-ray
Copy link
Collaborator

Thanks for the PR, wil review this. thanks

Copy link
Collaborator

@nabhajit-ray nabhajit-ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FalcoSuessgott
Copy link
Author

Updated the server profile example and added an Enum with all currently supported Warnings

@nabhajit-ray
Copy link
Collaborator

Hi @FalcoSuessgott , seems there is an error with the PR. Error is below:
image

@FalcoSuessgott
Copy link
Author

FalcoSuessgott commented Nov 8, 2023

Fixed the example, can you check?

Copy link
Collaborator

@nabhajit-ray nabhajit-ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akshith-gunasheelan
Copy link
Collaborator

@FalcoSuessgott you can merge your PR and make the required changes in terraform and raise it for review

@FalcoSuessgott
Copy link
Author

@FalcoSuessgott you can merge your PR and make the required changes in terraform and raise it for review

I dont understand, I think you have to merge this PR and tag it, so I can use this new oneview-golang version in the oneview terraform provider.

@akshith-gunasheelan akshith-gunasheelan merged commit 30a3fb8 into HewlettPackard:master Nov 9, 2023
1 check passed
@akshith-gunasheelan
Copy link
Collaborator

akshith-gunasheelan commented Nov 9, 2023

Hi @FalcoSuessgott ,
You can see the changes in the terraform provider by -

  1. Cloning the oneview-terraform-provider master branch
  2. Run the command "go get github.com/HewlettPackard/oneview-golang@master"
  3. Run "go mod vendor"

Doing this will allow the latest golang changes to appear in the terraform provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: The selected server hardware has health status other than "OK"
3 participants