-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(serverprofile): add force param to serverprofile creation #403
feat(serverprofile): add force param to serverprofile creation #403
Conversation
Thanks for the PR, wil review this. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples needs to be added/edited
https://github.com/HewlettPackard/oneview-golang/blob/master/examples/server_profiles.go
Updated the server profile example and added an Enum with all currently supported Warnings |
Hi @FalcoSuessgott , seems there is an error with the PR. Error is below: |
Fixed the example, can you check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@FalcoSuessgott you can merge your PR and make the required changes in terraform and raise it for review |
I dont understand, I think you have to merge this PR and tag it, so I can use this new oneview-golang version in the oneview terraform provider. |
Hi @FalcoSuessgott ,
Doing this will allow the latest golang changes to appear in the terraform provider. |
This PR introduces the feature to specifiy the force flag for the server profile creation:
This is needed in order to fix HewlettPackard/terraform-provider-oneview#548 in the oneview terraform provider.
LMK what you think :)