Clicking outside of dialog window in progress should NOT close the window. Should instead ask user to cancel.

[azenyr]

Describe the bug

While a popup/dialog window is open, for example, while adding a game and the installer is executing, clicking outside of this popup by mistake closes the popup but the game is still installing, so the game still gets installed but not added to the launcher. Same thing happens when installing stuff in winetricks. Clicking outside the window by mistake closes winetricks popup, so we lose track of the installation progress of winetricks components. Opening the window again sometimes resumes the progress, but many times doesn't so we don't know if a winetricks component is actually installed or not, and I have to install components again to be sure.

Either way, this is bad UX. Windows or popups/dialogs that have currently running processes should not be closed by clicking outside of them. They should also not be closed by the X button. Doing so, should ask the user if they want to cancel, and if yes, should correctly cancel the installation and clean leftover files.

Add logs

---

Steps to reproduce

1. Add a game, open its installer.
2. While the installer is running, click outside of the "Add game" window on the launcher.
3. The "Add game" window gets closed, but the game installation still continues, so there will be many GBs of lost leftover files somewhere in the disk.
4. Similar thing happens with the winetricks popup window.

Expected behavior

When clicking X or clicking outside of a currently running process dialog window, it should instead ask the user if he wants to cancel the currently running process (if its even possible to cancel it). User should be able to click "Cancel Process" or "Continue". If cancelled, heroic launcher should try to clean the leftover files of a cancelled/failed installation.

Screenshots

No response

Heroic Version

Latest Stable

System Information

• OS: Nobara (Fedora) 40 Desktop. Also tested on the Steam Deck, same exact behaviour.

Additional information

No response

[arielj]

There's an Accessibility setting to disable closing the dialogs when clicking outside. Check in the Accessibility settings in the sidebar of heroic.

It's not exactly what you are asking (asking the user to cancel), but it prevents the problem of closing dialogs by mistake.

[arielj]

Also, this seems like a duplicate of #3194 (that one only mentions the Add Game dialog, but it's the same idea)