Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REC] Frost Mage Flurry Recommendation issue during BL #4260

Open
5 tasks done
yokaii4 opened this issue Dec 23, 2024 · 2 comments
Open
5 tasks done

[REC] Frost Mage Flurry Recommendation issue during BL #4260

yokaii4 opened this issue Dec 23, 2024 · 2 comments
Assignees
@Hekili
Labels
recommendation Ticket is a proposed change to action priorities. triage Issue needs initial triage to determine if action needs to be taken.

Comments

@yokaii4
Copy link

yokaii4 commented Dec 23, 2024

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this issue (above) so that it describes the issue I am reporting.
  • I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

Mage - Frost

Describe the Issue

During Icy Veins in Spellsinger build (doesn't matter m+ or ST talents) during BL I have noticed that sometimes the addon recommends flurry without a frostbolt/glacial spike cast but instead a Ice lance. I suppose this issue happens because with bl + freezing winds the addon can't keep up the recommendation and it bricks. Maybe a solution could be to force the flurry logic in certain moments during freezing winds?

NOTE: it is very hard to get a perfect snapshot since with BL and Icy veins it's very hard to capture the exact moment, therefore I highly suggest you to log directly and check it by yourself

How to Reproduce

  1. enter game as frost mage with Spellsinger talents
  2. go to AOE dummies
  3. execute rotation with BL
  4. After about 15-20s notice how some flurry casts get stuck/not being recommended properly

Snapshot (Link)

https://pastebin.com/jCkRBHtt // https://pastebin.com/eMJpkFX1

Raidbots Sim Report (Link)

https://www.raidbots.com/simbot/report/a6zv2ij6TzXdzE9UTdDCGN

Additional Information

No response

Contact Information

yokaii__
@yokaii4 yokaii4 added recommendation Ticket is a proposed change to action priorities. triage Issue needs initial triage to determine if action needs to be taken. labels Dec 23, 2024
@yokaii4
Copy link
Author

yokaii4 commented Dec 23, 2024

@syrifgit this is the flurry issue i was mentioning. Apparently it is way easier to reproduce it with BL, whilst without it it's a low chance

@yokaii4 yokaii4 closed this as completed Dec 23, 2024
@yokaii4 yokaii4 reopened this Dec 23, 2024
@yokaii4
Copy link
Author

yokaii4 commented Dec 23, 2024 •
edited
Loading

After speaking with the mage community I have an answer for this issue: It's a machine error (The sim also does it). What happens is that as per Icy Veins guide https://www.icy-veins.com/wow/frost-mage-pve-dps-rotation-cooldowns-abilities?area=area_7 you can use a flurry dry if you have no other spells besides frostbolt to use. However, the machine (sim) doesn't wait those 0.5s that will refresh the next finger of frost, making enhanced ice lances rolling normally. seems to be kind of a grey area since realistically speaking a human wouldn't be able to notice in 0.5s that so they would probably just roll the ice lance, but since hekili is a "machine" it would be normal for it to suggest it. I am leaving this ticket open just to let you decide if this would require a change in its logic or not, mainly because the addon might switch up suggestions very quickly in certain instances making it confusing for some users

P.S.: the community prompted me to also sim at 5 minutes since " a 1m sim is going to give very skewed results and you'll probably see some odd things going on" so here it is https://www.raidbots.com/simbot/report/eTfCXG6Q8zqP56x67mUgNA

joshjau added a commit to joshjau/hekili that referenced this issue Dec 23, 2024
@joshjau
[Frost Mage] Add Fingers of Frost timing check to Flurry conditions
eb09288 
Addresses issue Hekili#4260 where Flurry recommendations could occur at suboptimal times during high-haste situations (Bloodlust + Icy Veins).

Changes:
- Added condition `(!buff.fingers_of_frost.react|buff.fingers_of_frost.remains>1)` to Flurry usage in single-target, cleave, and AoE action lists
- This ensures Flurry isn't recommended if Fingers of Frost is about to proc within 1 second
- Makes recommendations more practical for human players while maintaining proper Flurry usage after Frostbolt/Glacial Spike casts

The change helps prevent rapid recommendation switches during high-haste periods while still allowing optimal Flurry usage patterns. This makes the addon's suggestions more consistent and easier to follow during intense combat situations.
joshjau added a commit to joshjau/hekili that referenced this issue Dec 23, 2024
@joshjau
[Frost Mage] Add Fingers of Frost timing check to Flurry conditions
7d44fcb 
Potentially addresses issue Hekili#4260 where Flurry recommendations could occur at suboptimal times during high-haste situations (Bloodlust + Icy Veins).

Changes:
- Added condition `(!buff.fingers_of_frost.react|buff.fingers_of_frost.remains>1)` to Flurry usage in single-target, cleave, and AoE action lists
- This ensures Flurry isn't recommended if Fingers of Frost is about to proc within 1 second
- Makes recommendations more practical for human players while maintaining proper Flurry usage after Frostbolt/Glacial Spike casts

The change helps prevent rapid recommendation switches during high-haste periods while still allowing optimal Flurry usage patterns. This makes the addon's suggestions more consistent and easier to follow during intense combat situations.
@joshjau joshjau mentioned this issue Dec 23, 2024
Closed
joshjau added a commit to joshjau/hekili that referenced this issue Dec 24, 2024
@joshjau
Updated the PR to better handle the Flurry recommendation issue repor…
42f40ee 
…ted in Hekili#4260.

Changes:
- Modified Flurry timing conditions to be more conservative during high-haste periods
- Increased FoF timing check from 1s to 1.5s for better human playability
- Added specific handling for Freezing Winds + Icy Veins interaction with:
  `(!talent.freezing_winds|!buff.icy_veins.up|buff.fingers_of_frost.remains>2)`

This should prevent the addon from recommending Flurry at suboptimal times during Bloodlust + Icy Veins windows, particularly with the Freezing Winds talent, while still maintaining proper Flurry usage after Frostbolt/Glacial Spike casts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hekili Hekili

Labels
recommendation Ticket is a proposed change to action priorities. triage Issue needs initial triage to determine if action needs to be taken.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Hekili @yokaii4