Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Balance] Fix Eclipse entry sequence with Lunar's Calling talent #4262

Closed
wants to merge 1 commit into from

Conversation

joshjau
Copy link
Contributor

@joshjau joshjau commented Dec 23, 2024

Potentially fixes #4248

This PR addresses an issue with Balance Druid Eclipse entry sequences when using the Lunar's Calling talent. Previously, the addon may incorrectly suggest ability switches during Eclipse entry casts, particularly when trying to enter Lunar Eclipse.

Changes:

  1. Updated DruidBalance.simc to prevent ability switching during Eclipse entry:
  • Added Eclipse counter and previous GCD checks to Wrath/Starfire conditions
  • Ensures proper spell sequencing when entering Eclipse phases
  • Prevents suggestions from changing mid-cast during Eclipse entry sequences
  1. Enhanced Eclipse state management in DruidBalance.lua:
  • Added logic to prevent state changes during critical Eclipse entry casts
  • Improved state transition handling during Eclipse sequences
  • Better handling of the Lunar's Calling talent interaction

The changes ensure that:

  • Double Wrath casts work properly when entering Lunar Eclipse with Lunar's Calling
  • The rotation doesn't flip-flop between suggestions during Eclipse entry
  • Eclipse entry sequences remain smooth and consistent

Potentially fixes Hekili#4248

This PR addresses an issue with Balance Druid Eclipse entry sequences when using the Lunar's Calling talent. Previously, the addon would incorrectly suggest ability switches during Eclipse entry casts, particularly when trying to enter Lunar Eclipse.

Changes:

1. Updated DruidBalance.simc to prevent ability switching during Eclipse entry:
- Added Eclipse counter and previous GCD checks to Wrath/Starfire conditions
- Ensures proper spell sequencing when entering Eclipse phases
- Prevents suggestions from changing mid-cast during Eclipse entry sequences

2. Enhanced Eclipse state management in DruidBalance.lua:
- Added logic to prevent state changes during critical Eclipse entry casts
- Improved state transition handling during Eclipse sequences
- Better handling of the Lunar's Calling talent interaction

The changes ensure that:
- Double Wrath casts work properly when entering Lunar Eclipse with Lunar's Calling
- The rotation doesn't flip-flop between suggestions during Eclipse entry
- Eclipse entry sequences remain smooth and consistent
Copy link
Owner

@Hekili Hekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm revieiwng this, but honestly Eclipse modeling has always been a pain. I'm not sure of the necessity of the changes in DruidBalance.lua, why there's a need to forego updating the Eclipse state (unless that better matches what happens in-game). I want to make sure we apply a fix and not a bandage that doesn't hold up vs. future mechanics.

@joshjau joshjau closed this Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REC] Balance Druid entering eclipse issue
2 participants