Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REC] Balance Druid entering eclipse issue #4248

Open
5 tasks done
Smudgiee opened this issue Dec 14, 2024 · 3 comments
Open
5 tasks done

[REC] Balance Druid entering eclipse issue #4248

Smudgiee opened this issue Dec 14, 2024 · 3 comments
Assignees
Labels
recommendation Ticket is a proposed change to action priorities. triage Issue needs initial triage to determine if action needs to be taken.

Comments

@Smudgiee
Copy link

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this issue (above) so that it describes the issue I am reporting.
  • I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

Druid - Balance

Describe the Issue

When it suggests to go into Lunar eclipse, it says to press wrath, I press wrath then it shows starfire and towards the end of the cast it will quickly swap to wrath again. It should be doing double wrath and not suggesting to use other abilities between the cast of wrath etc when entering an eclipse according to simc breakdown.

So basically it's suggesting wrath to get ready to enter new eclipse but then it swaps to starfire while casting wrath, then back to wrath suggestion towards end of cast. It will also suggest using other abilities whilst casting first wrath which it shouldn't.

How to Reproduce

follow the rotation in aoe situtation and check when its about to try and enter an eclipse. I only tested aoe so far, so not sure if it also happens going into solar eclipse.
Using m+ talents as seen in my log.

Snapshot (Link)

https://pastebin.com/N752nATE

Raidbots Sim Report (Link)

No response

Additional Information

No response

Contact Information

No response

@Smudgiee Smudgiee added recommendation Ticket is a proposed change to action priorities. triage Issue needs initial triage to determine if action needs to be taken. labels Dec 14, 2024
@Smudgiee
Copy link
Author

Smudgiee commented Dec 14, 2024

Can confirm this is only using Elune's Chosen with Lunars Calling. Without Lunars Calling it works as intended.

@joshjau
Copy link
Contributor

joshjau commented Dec 15, 2024

Possible fix, replace lines 46, 47:

actions.aoe+=/wrath,if=variable.enter_lunar&(!variable.eclipse|variable.eclipse_remains<cast_time)
actions.aoe+=/starfire,if=!variable.enter_lunar&(!variable.eclipse|variable.eclipse_remains<cast_time)

With:

actions.aoe+=/wrath,if=variable.enter_lunar&(!variable.eclipse|variable.eclipse_remains<cast_time)&(!prev_gcd.1.wrath|prev_gcd.1.wrath&!prev_gcd.2.wrath)
actions.aoe+=/starfire,if=!variable.enter_lunar&(!variable.eclipse|variable.eclipse_remains<cast_time)&(!prev_gcd.1.starfire|prev_gcd.1.starfire&!prev_gcd.2.starfire)

These changes:

  • Add conditions to check previous casts using prev_gcd to ensure proper spell sequencing
  • Remove the redundant conditions that were causing the flip-flopping behavior
  • Ensure that when entering Lunar Eclipse with Lunar's Calling, it will properly suggest double Wrath casts without interruption

You must export the string into the .lua file with the new priorities depending on how you address this, but it may be worth trying until Hekili visits this, as I may be wrong or need a better method.

@Smudgiee
Copy link
Author

Thanks for the try but it seems to still be doing it sadly. Might also be something to do within in the LUA, not entirely sure because it's smooth for everything other than this build. I will try again later, only had a few mins to check but it didn't seem to change anything.

joshjau added a commit to joshjau/hekili that referenced this issue Dec 23, 2024
Potentially fixes Hekili#4248

This PR addresses an issue with Balance Druid Eclipse entry sequences when using the Lunar's Calling talent. Previously, the addon would incorrectly suggest ability switches during Eclipse entry casts, particularly when trying to enter Lunar Eclipse.

Changes:

1. Updated DruidBalance.simc to prevent ability switching during Eclipse entry:
- Added Eclipse counter and previous GCD checks to Wrath/Starfire conditions
- Ensures proper spell sequencing when entering Eclipse phases
- Prevents suggestions from changing mid-cast during Eclipse entry sequences

2. Enhanced Eclipse state management in DruidBalance.lua:
- Added logic to prevent state changes during critical Eclipse entry casts
- Improved state transition handling during Eclipse sequences
- Better handling of the Lunar's Calling talent interaction

The changes ensure that:
- Double Wrath casts work properly when entering Lunar Eclipse with Lunar's Calling
- The rotation doesn't flip-flop between suggestions during Eclipse entry
- Eclipse entry sequences remain smooth and consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recommendation Ticket is a proposed change to action priorities. triage Issue needs initial triage to determine if action needs to be taken.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants