Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add a max target consideration for rotation. #4226

Open
4 tasks done
iSkyzzle opened this issue Nov 27, 2024 · 2 comments
Open
4 tasks done

[FEATURE] Add a max target consideration for rotation. #4226

iSkyzzle opened this issue Nov 27, 2024 · 2 comments
Assignees
Labels
backlog Low priority; awaiting time/resource availability. enhancement

Comments

@iSkyzzle
Copy link

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this request and was not able to find one.
  • I edited the title of this feature request (above) so that it describes the issue I am reporting.

Feature Request

I would like a tool that I could add a maximum target recommendation for the rotation.

Example: I play frost mage on silken court mythic. Since frost has a different rotation for 1 target, 2 target, and aoe the addon takes into account the scarabs that spawn and changes to AoE when they are out which is unimportant as a frost mage. Being able to cap the max targets to 2 would be great so that the rotation doesn't change when the adds spawn.

Thanks!

Additional Information

No response

Contact Information

No response

@iSkyzzle iSkyzzle added enhancement triage Issue needs initial triage to determine if action needs to be taken. labels Nov 27, 2024
@syrifgit
Copy link
Collaborator

Could be useful, added to backlog.

@syrifgit syrifgit added backlog Low priority; awaiting time/resource availability. and removed triage Issue needs initial triage to determine if action needs to be taken. labels Dec 22, 2024
@Hekili
Copy link
Owner

Hekili commented Dec 23, 2024

I think this is interesting and I'm not opposed, though I am not sure this is the right solution for the issue that you're reporting.

I probably need to add a feature that lets people control which NPCs are ignored instead of the hardcoded list that is in the addon. But now both of those ideas are in the backlog. :)

In the meantime, you might be able to type /run rawset( Hekili.State, "max_targets", 2 ) as a macro before your Silken Court pulls; it will persist until you /reload and should cap ALL displays at 2 targets for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Low priority; awaiting time/resource availability. enhancement
Projects
None yet
Development

No branches or pull requests

3 participants