You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Although, I am not sure about what version requirements we should have. There might also be an issue with saving to parquet in python3.12 that we should test, at least based on the pyarrow requirements listed in awkward requirements-test-full.txt
h5py and awkward could be considered optional at some point if we want to handle those dependencies on the fly, but it may just be better to include them so that things work out of the box.
For DarkNews it might make sense to make it an optional dependency since it is not necessary for all types of injection, and one may want to choose a particular or custom built version of it?
This would require hiding the DarkNews imports in some way and adding in some version logic when an import is attempted.
The text was updated successfully, but these errors were encountered:
#64 fixes some of these issues, but does still require DarkNews.
At the moment the python code is not set up to operate without DarkNews so this behavior makes sense.
I'm opening up a separate issue (#65) for making those modifications and closing this one out with the #64 PR
https://github.com/Harvard-Neutrino/LeptonInjector/blob/6c5e819d1407f9ee4a276a8c74ae1fcbad4777dc/pyproject.toml#L40-L44
We should add our actual package dependencies since this will eventually be published to pypi.
From what I can tell we should at least have:
Although, I am not sure about what version requirements we should have. There might also be an issue with saving to parquet in python3.12 that we should test, at least based on the
pyarrow
requirements listed inawkward
requirements-test-full.txth5py
andawkward
could be considered optional at some point if we want to handle those dependencies on the fly, but it may just be better to include them so that things work out of the box.For DarkNews it might make sense to make it an optional dependency since it is not necessary for all types of injection, and one may want to choose a particular or custom built version of it?
This would require hiding the DarkNews imports in some way and adding in some version logic when an import is attempted.
The text was updated successfully, but these errors were encountered: