Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing package dependencies #56

Closed
austinschneider opened this issue Feb 24, 2024 · 1 comment · Fixed by #64
Closed

Missing package dependencies #56

austinschneider opened this issue Feb 24, 2024 · 1 comment · Fixed by #64
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@austinschneider
Copy link
Collaborator

https://github.com/Harvard-Neutrino/LeptonInjector/blob/6c5e819d1407f9ee4a276a8c74ae1fcbad4777dc/pyproject.toml#L40-L44

We should add our actual package dependencies since this will eventually be published to pypi.

From what I can tell we should at least have:

dependencies = [
    "numpy",
    "scipy",
    "awkward",
    "pyarrow",
    "h5py",
    "DarkNews"
]

Although, I am not sure about what version requirements we should have. There might also be an issue with saving to parquet in python3.12 that we should test, at least based on the pyarrow requirements listed in awkward requirements-test-full.txt

h5py and awkward could be considered optional at some point if we want to handle those dependencies on the fly, but it may just be better to include them so that things work out of the box.

For DarkNews it might make sense to make it an optional dependency since it is not necessary for all types of injection, and one may want to choose a particular or custom built version of it?

This would require hiding the DarkNews imports in some way and adding in some version logic when an import is attempted.

@austinschneider austinschneider added bug Something isn't working enhancement New feature or request labels Feb 24, 2024
@austinschneider austinschneider self-assigned this Feb 24, 2024
@austinschneider
Copy link
Collaborator Author

#64 fixes some of these issues, but does still require DarkNews.
At the moment the python code is not set up to operate without DarkNews so this behavior makes sense.
I'm opening up a separate issue (#65) for making those modifications and closing this one out with the #64 PR

@austinschneider austinschneider linked a pull request Mar 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant