-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Options menu revamp pt 2 #22
Comments
👍 will get started asap |
btw are you working on the dev branch or gh-pages? I'm still not at all satisfied with the state of the code on dev, but also don't at all have the time to fix it. |
Was planning on working on dev- the node.js stuff isnt perfect but its good On Sun, Oct 26, 2014 at 3:11 PM, iluvredwall [email protected]
Manan "Stay hungry, stay foolish" - Steve Jobs |
It should be fine to merge anytime - all the code works and everything (afaik) - I just never bothered because i wasn't sure when I'd stop working on it (I didn't really want to be merging into gh-pages all the time), and I haven't had the time since I stopped. I think there two major things I wanted to work on as far as refactoring goes:
Basically the the first bit is readability and the second bit is all just making the code more object-oriented. Both of these could be improved in more than just these two places, but I'm pretty sure that's where each is the worst. I'll probably get back to working on this over the break (unless anyone else wants to?).
There's probably some other stuff I missed, but that's all I've been keeping in my notes/todo list. i probably shouldve updated the issues with this stuff sometime, but that's hard. |
Actually, when I edit comments, the edited version doesn't get sent in the email notifications, does it? |
desktop:
mobile:
The text was updated successfully, but these errors were encountered: