Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resourceType or attribute evaluation #3

Open
plynchnlm opened this issue Apr 8, 2019 · 0 comments
Open

resourceType or attribute evaluation #3

plynchnlm opened this issue Apr 8, 2019 · 0 comments

Comments

@plynchnlm
Copy link
Collaborator

(Moved from lhncbc/fhirpath.js, originally by niquola.)

It looks like you are testing whether the name is capitalized to determine whether it is a resource name, which I think is not the right test. Bryn said, "That when resolving an identifier that is also the root of a FHIRPath expression, it is resolved as a type name first, and if it resolves to a type, it must resolve to the type of the context (or a supertype). Otherwise, it is resolved as a path on the context." (From https://chat.fhir.org/#narrow/stream/115-fhirpath/topic/Resource.20names.20in.20FHIRPath).

Also, per that comment, it sounds like MemberInvocation is not the right place to make the check for a resource name, since in "Patient.name.given" it also gets called for "name" and "given" (i.e., non-root nodes).

Discuss topic in fhir chat, design better implementation and make decision

plynchnlm added a commit to LHNCBC/fhirpath.js that referenced this issue Jan 6, 2020
…p to master

* commit '049d62241c11d6d887827a5d3db2168eaf7bf171':
  Added missing files to browser-ready zip (the release file).  I manually fixed the zip release file for 1.0.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant