Error info

[busslina]

Seems that any error or throw happened on a capsule body (before the return) is not printed in the output. Instead this is printed: TypeError: null: type 'Null' is not a subtype of type 'DataflowGraphNode'. I think this is due because you might be catching errors. Do you think it could be useful to print the error details?

[GregoryConrad]

Could you please provide a reproducer? This test case is working as expected:

  test('errors propagate correctly', () {
    Never throwsErrorCapsule(CapsuleHandle use) =>
        throw UnsupportedError('capsule should throw');
    Never dependentCapsule(CapsuleHandle use) => use(throwsErrorCapsule);
    final container = useContainer();
    expect(
      () => container.read(throwsErrorCapsule),
      throwsA(isA<UnsupportedError>()),
    );
    expect(
      () => container.read(dependentCapsule),
      throwsA(isA<UnsupportedError>()),
    );
  });

[busslina]

I write here just for the case this issue was lost, as reminder.

[GregoryConrad]

Haven’t forgot, just been super busy :)

[busslina]

Thanks, so I simplified it here: https://github.com/busslina/rearch-issue

I discovered that seems to happen on web (edge and chrome) but not on windows.

Edge:

.\tools\run-edge.ps1

Chrome:

.\tools\run-chrome.ps1

Windows:

.\tools\run-windows.ps1

[GregoryConrad]

I did try to reproduce this in a test a few days ago and failed to do so--

Probably because I totally misread that original error message:

TypeError: null: type 'Null' is not a subtype of type 'DataflowGraphNode'

ReArch was written in Dart 3, and as such is entirely null-safe. The above should be impossible to hit.

Especially since you're seeing different behavior on web/desktop, this is highly likely a bug in the Map implementation for Flutter web. I'd suggest filing an issue over at Flutter and CC me on the issue. They'll want a reproducer, and probably without external dependencies, meaning you will have to inline things from ReArch like I did here: flutter/flutter#153536. That just involves copy/pasting all the appropriate parts of ReArch into the main.dart file itself. If that is proving to be too hard, just post the reproducer (from above) with ReArch as a dependency, and I can help with in-lining the relevant parts on the issue if they ask for a no-dependency reproducer.

Funny enough, this is the second Map implementation bug I've seen in the past few weeks; see #209. Makes me wonder how many other bugs are hiding in the Map implementation...

[busslina]

Thanks, I'm going to try this coming week to do that issue (I hate Flutter GitHub issues template...).