Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyError if index has nonexistent columnname #29

Open
fschloesser opened this issue Jul 13, 2017 · 2 comments
Open

KeyError if index has nonexistent columnname #29

fschloesser opened this issue Jul 13, 2017 · 2 comments
Assignees

Comments

@fschloesser
Copy link
Collaborator

If the user specifies a column in as index that doesn't exist a KeyError gets thrown.
What is the way to handle this? We could
a) throw an error (that explains the problem better to the user than now) and abort or
b) warn and try to fix this by either deleting the faulty column specifier or generating a new index from scratch.
I would do variant a)

@fschloesser
Copy link
Collaborator Author

fschloesser commented Jul 13, 2017

to reproduce run this eval file with the benchmarkdata:

<?xml version="1.0" ?>
<Evaluation defaultgroup="SCIP" index="ProblemName Indic Solver" indexsplit="1">
	<Column active="True" origcolname="Status" reduction="meanOrConcat" />
	<FilterGroup filtertype="intersection" name="all">
		<Filter anytestrun="one" expression1="SolvingTime" expression2="10" operator="ge"/>
	</FilterGroup>
</Evaluation>

@GregorCH
Copy link
Owner

Let's wait with that until I have finished the reduction index #21

@GregorCH GregorCH self-assigned this Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants