Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voice receiving support #9

Open
szerookii opened this issue Jan 31, 2023 · 5 comments
Open

Add voice receiving support #9

szerookii opened this issue Jan 31, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@szerookii
Copy link
Member

No description provided.

@szerookii szerookii added the enhancement New feature or request label Jan 31, 2023
@szerookii szerookii self-assigned this Jan 31, 2023
@MrWong99
Copy link

I would really much like (and need) that👍🏻

I would be willing to try implementing this feature.
Would that be okay or is someone already working on this?

Do you anticipate any major hurdles that one must tackle to add this feature?
So far I just got the sending part to work, which was already a hassle for me as I am bad at audio de-/encoding...

@szerookii
Copy link
Member Author

Hello, we already have audio receiving done on the #8 issue & feature/voice branch. You can still make a pull-request we can see if we can improve our implementation. Otherwise, no one is planning to do the reception at the moment, if you want to do a pull-request, it's welcome. 👀

@MrWong99
Copy link

MrWong99 commented May 12, 2024

Wait is there a typo or do you actually mean receiving is already done in the branch?

If so: how would I get my hands at some of that audio data send by others?

If Not I can give it my best shot if it is not yet implemented. But I already saw that the Discord Voice Docs are a bit sparse when it comes to receiving. I can still lurk in other client implementations though 😆

@szerookii
Copy link
Member Author

Wait is there a typo or do you actually mean receiving is already done in the branch?

If so: how would I get my hands at some of that audio data send by others?

If Not I can give it my best shot if it is not yet implemented. But I already saw that the Discord Voice Docs are a bit sparse when it comes to receiving. I can still lurk in other client implementations though 😆

Yep, sending. Huge typo lol

@MrWong99
Copy link

I will devote some free time to look into the matter then.

And btw really nice library already! I was worried I needed to do the UDP package management or audio encryption myself but turns out: just encoding correctly and calling connection.Write() a bunch of times is enough 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants