Deduplicate rendered manifests upon release #1437
Labels
priority: p3
Desirable enhancement or fix. May not be included in next release.
type: cleanup
An internal cleanup or hygiene concern.
As of release
v0.6.0
(PR: #1425), release Kubernetes manifests are no longer copy-pasted from a staging directory. Instead, they are programmatically generated usingskaffold render
(see https://github.com/GoogleCloudPlatform/bank-of-anthos/blob/release/v0.6.0/docs/releasing/make-release.sh#L60-L72).Since we want to keep parity with the pre-
v0.6.0
versions of Bank of Anthos which had each microservice in a different file, this causes some issues wherein duplicate Kubernetes objects are rendered in multiple files:For release
v0.6.0
, I have taken the action of manually:config.yaml
objects from all other filesledger-db.yaml
andaccounts-db.yaml
objects from all other filesjwt-secret.yaml
object from all other filesconfig.yaml
file (not sure if it's the right place for it, it may deserve its own file, but that would require breaking a tutorial or two).We should look into automating the above steps for new releases, or finding an alternative solution. I have looked into
diff
,comm
, and third-party tools likedyff
, but none of them works out great when diff'ing out entire objects.The text was updated successfully, but these errors were encountered: